Bug 171281 - Improve wavy underline rendering
Summary: Improve wavy underline rendering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-25 11:37 PDT by Dave Hyatt
Modified: 2017-04-26 08:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.63 KB, patch)
2017-04-25 11:40 PDT, Dave Hyatt 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2017-04-25 11:37:56 PDT 
Improve wavy underline rendering
Comment 1 Dave Hyatt 2017-04-25 11:40:00 PDT 
Created attachment 308119 [details]
Patch
Comment 2 Sam Weinig 2017-04-25 11:53:01 PDT 
Comment on attachment 308119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308119&action=review

I take it, the only real way to regression test this is pixel tests?

> Source/WebCore/style/InlineTextBoxStyle.cpp:93
>      // Distance between decoration's axis and Bezier curve's control points.
>      // The height of the curve is based on this distance. Use a minimum of 6 pixels distance since
>      // the actual curve passes approximately at half of that distance, that is 3 pixels.
>      // The minimum height of the curve is also approximately 3 pixels. Increases the curve's height
>      // as strokeThickness increases to make the curve look better.

Is this comment still correct?
Comment 3 Dave Hyatt 2017-04-26 08:59:11 PDT 
Fixed in r215802.