RESOLVED FIXED 171270
[GTK] Add libgpg-error, libgcrypt libraries to JHBuild 
https://bugs.webkit.org/show_bug.cgi?id=171270
Summary [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
Zan Dobersek
Reported 2017-04-25 05:14:54 PDT
[GTK] Add libgpg-error, libgcrypt libraries to JHBuild
Attachments
Patch (2.57 KB, patch)
2017-04-25 05:17 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (4.14 KB, patch)
2017-04-25 07:06 PDT, Zan Dobersek 		mcatanzaro: review+
mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-04-25 05:17:06 PDT
Created attachment 308094 [details] Patch
Zan Dobersek
Comment 2 2017-04-25 07:06:16 PDT
Created attachment 308098 [details] Patch
Michael Catanzaro
Comment 3 2017-04-25 07:15:33 PDT
Comment on attachment 308098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308098&action=review > Tools/ChangeLog:20 > +2017-04-25 Zan Dobersek <zdobersek@igalia.com> > + > + [GTK] Add libgpg-error, libgcrypt libraries to JHBuild > + https://bugs.webkit.org/show_bug.cgi?id=171270 > + > + Reviewed by NOBODY (OOPS!). Remove this duplicate changelog entry! > Tools/gtk/jhbuild.modules:621 > + <dependencies> > + <dep package="libgpg-error"/> > + </dependencies> Style: put the branch tag first, then the dependencies tag next. > Tools/gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch:12 > ++ // Enforce the use of /dev/urandom for testing of the libgcrypt-based > ++ // Web Crypto implementation testing in WebKit. > ++ // DO NOT USE THIS PATCH OUTSIDE OF TESTING ENVIRONMENTS. > ++ level = 0; Nice!
Zan Dobersek
Comment 4 2017-04-25 09:46:02 PDT
Committed r215739: <http://trac.webkit.org/changeset/215739>
Note You need to log in before you can comment on or make changes to this bug.