Bug 171267 - [GTK] Remote inspector should support inspecting targets with previous version of backend commands
Summary: [GTK] Remote inspector should support inspecting targets with previous versio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-04-25 03:13 PDT by Carlos Garcia Campos
Modified: 2017-04-27 09:56 PDT (History)
4 users (show)

See Also:


Attachments
Patch (18.31 KB, patch)
2017-04-25 03:29 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-04-25 03:13:42 PDT
There's a FIXME for this in the code. The remote inspector proxy allows to pass a backend commands URL when inspecting a target. That URL is not empty is used as Protocol/InspectorBackendCommands.js in the inspector instead of the local copy. We are currently assuming that both ends use the same version of that file.
Comment 1 Carlos Garcia Campos 2017-04-25 03:29:25 PDT
Created attachment 308081 [details]
Patch

I'm using SHA1, and not SHA256, to compute the backend commands hash because we don't have access to PAL from JavaScriptCore.
Comment 2 Carlos Garcia Campos 2017-04-27 05:28:58 PDT
Committed r215862: <http://trac.webkit.org/changeset/215862>
Comment 3 Don Olmstead 2017-04-27 09:56:52 PDT
(In reply to Carlos Garcia Campos from comment #1)
> Created attachment 308081 [details]
> Patch
> 
> I'm using SHA1, and not SHA256, to compute the backend commands hash because
> we don't have access to PAL from JavaScriptCore.

Should we move those things into WTF?