Bug 171261 - [GTK] Add WebKitInspectorWindow to create inspector windows from local and remote inspector
Summary: [GTK] Add WebKitInspectorWindow to create inspector windows from local and re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-04-25 00:00 PDT by Carlos Garcia Campos
Modified: 2017-04-25 08:24 PDT (History)
3 users (show)

See Also:


Attachments
Patch (15.16 KB, patch)
2017-04-25 00:03 PDT, Carlos Garcia Campos
mcatanzaro: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-elcapitan (1.75 MB, application/zip)
2017-04-25 01:28 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-04-25 00:00:27 PDT
The code is currently duplicated in WebInspectorProxyGtk.cpp and RemoteWebInspectorProxyGtk.cpp. We can simplify it by using a common widget in both places.
Comment 1 Carlos Garcia Campos 2017-04-25 00:03:38 PDT
Created attachment 308073 [details]
Patch
Comment 2 Build Bot 2017-04-25 01:28:54 PDT
Comment on attachment 308073 [details]
Patch

Attachment 308073 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3600142

New failing tests:
webrtc/datachannel/basic.html
Comment 3 Build Bot 2017-04-25 01:28:55 PDT
Created attachment 308075 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Michael Catanzaro 2017-04-25 07:45:00 PDT
Comment on attachment 308073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308073&action=review

> Source/WebKit2/UIProcess/gtk/WebKitInspectorWindow.cpp:30
> +#include <glib/gi18n-lib.h>

Oh wow... this exists....
Comment 5 Michael Catanzaro 2017-04-25 07:45:56 PDT
Comment on attachment 308073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308073&action=review

> Source/WebKit2/UIProcess/gtk/WebKitInspectorWindow.h:13
> + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY

Should grab a newer copy of the license header (we normally just say "APPLE, INC." right?)
Comment 6 Carlos Garcia Campos 2017-04-25 08:24:48 PDT
Committed r215732: <http://trac.webkit.org/changeset/215732>