WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
171261
[GTK] Add WebKitInspectorWindow to create inspector windows from local and remote inspector
https://bugs.webkit.org/show_bug.cgi?id=171261
Summary
[GTK] Add WebKitInspectorWindow to create inspector windows from local and re...
Carlos Garcia Campos
Reported
2017-04-25 00:00:27 PDT
The code is currently duplicated in WebInspectorProxyGtk.cpp and RemoteWebInspectorProxyGtk.cpp. We can simplify it by using a common widget in both places.
Attachments
Patch
(15.16 KB, patch)
2017-04-25 00:03 PDT
,
Carlos Garcia Campos
mcatanzaro
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews113 for mac-elcapitan
(1.75 MB, application/zip)
2017-04-25 01:28 PDT
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2017-04-25 00:03:38 PDT
Created
attachment 308073
[details]
Patch
Build Bot
Comment 2
2017-04-25 01:28:54 PDT
Comment on
attachment 308073
[details]
Patch
Attachment 308073
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/3600142
New failing tests: webrtc/datachannel/basic.html
Build Bot
Comment 3
2017-04-25 01:28:55 PDT
Created
attachment 308075
[details]
Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Michael Catanzaro
Comment 4
2017-04-25 07:45:00 PDT
Comment on
attachment 308073
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=308073&action=review
> Source/WebKit2/UIProcess/gtk/WebKitInspectorWindow.cpp:30 > +#include <glib/gi18n-lib.h>
Oh wow... this exists....
Michael Catanzaro
Comment 5
2017-04-25 07:45:56 PDT
Comment on
attachment 308073
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=308073&action=review
> Source/WebKit2/UIProcess/gtk/WebKitInspectorWindow.h:13 > + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
Should grab a newer copy of the license header (we normally just say "APPLE, INC." right?)
Carlos Garcia Campos
Comment 6
2017-04-25 08:24:48 PDT
Committed
r215732
: <
http://trac.webkit.org/changeset/215732
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug