Bug 171261 – [GTK] Add WebKitInspectorWindow to create inspector windows from local and remote inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

The code is currently duplicated in WebInspectorProxyGtk.cpp and RemoteWebInspectorProxyGtk.cpp. We can simplify it by using a common widget in both places.

[Carlos Garcia Campos]

Created attachment 308073 [details]
Patch

[Build Bot]

Comment on attachment 308073 [details]
Patch

Attachment 308073 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3600142

New failing tests:
webrtc/datachannel/basic.html

[Build Bot]

Created attachment 308075 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Michael Catanzaro]

Comment on attachment 308073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308073&action=review

> Source/WebKit2/UIProcess/gtk/WebKitInspectorWindow.cpp:30
> +#include <glib/gi18n-lib.h>

Oh wow... this exists....

[Michael Catanzaro]

Comment on attachment 308073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308073&action=review

> Source/WebKit2/UIProcess/gtk/WebKitInspectorWindow.h:13
> + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY

Should grab a newer copy of the license header (we normally just say "APPLE, INC." right?)

[Carlos Garcia Campos]

Committed r215732: <http://trac.webkit.org/changeset/215732>