Bug 171259 - Web Inspector: TypeError:​ sourceCodeLocation.populateLiveDisplayLocationTooltip is not a function
Summary: Web Inspector: TypeError:​ sourceCodeLocation.populateLiveDisplayLocationTool...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on: 168709
Blocks:
  Show dependency tree / graph
 
Reported: 2017-04-24 20:08 PDT by Fujii Hironori
Modified: 2017-04-25 12:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2017-04-24 20:13 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2017-04-24 20:08:16 PDT 
I tested with GTK+ port, trunk@215680.

Steps:
1) Start MiniBrowser
2) Open Inspector
3) Open Timelines tab
4) Browsing some web pages

The following error happens:

> TypeError:​ sourceCodeLocation.populateLiveDisplayLocationTooltip is not a function. (In 'sourceCodeLocation.populateLiveDisplayLocationTooltip(linkElement)​', 'sourceCodeLocation.populateLiveDisplayLocationTooltip' is undefined)​ (at Main.js:​2310:​58)​
> createSourceCodeLocationLink @ Main.js:​2310:​58
> createCellContent @ TimelineDataGridNode.js:​161:​79
> createCell @ DataGridNode.js:​353:​45
> createCells @ DataGridNode.js:​111:​54
> element @ DataGridNode.js:​104:​25
> _updateVisibleRows @ DataGrid.js:​1144:​66
> layout @ DataGrid.js:​876:​32
> _layoutSubtree @ View.js:​250:​20
> _layoutSubtree @ View.js:​254:​32
> _visitViewTreeForLayout @ View.js:​327:​36
Comment 1 Fujii Hironori 2017-04-24 20:13:13 PDT 
Created attachment 308057 [details]
Patch
Comment 2 Joseph Pecoraro 2017-04-25 11:46:03 PDT 
Comment on attachment 308057 [details]
Patch

Nice! r=me
Comment 3 WebKit Commit Bot 2017-04-25 12:15:03 PDT 
Comment on attachment 308057 [details]
Patch

Clearing flags on attachment: 308057

Committed r215749: <http://trac.webkit.org/changeset/215749>
Comment 4 WebKit Commit Bot 2017-04-25 12:15:04 PDT 
All reviewed patches have been landed.  Closing bug.