Bug 171253 – Web Inspector: Open the new bug page in the new tab

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Opening in the new tab would be better than leaving the page I'm debugging.

[Nikita Vasilyev]

Created attachment 308020 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 308020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308020&action=review

r=me

> Source/WebInspectorUI/ChangeLog:10
> +        (sheetElement.innerHTML.div):
> +        (let.dismissOptionHTML.loadCompleted.string_appeared_here.dt.A.frivolous.exception.will.not.stop.me.dt.dd.a):

Err, these ChangeLog lines don't look right. Better to remove them when they look like this.

[Nikita Vasilyev]

Created attachment 308121 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 308121 [details]
Patch

Rejecting attachment 308121 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 308121, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Processing patch 308121 from bug 171253.
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebInspectorUI/ChangeLog
patch: **** malformed patch at line 18:  

patching file Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3603134

[Nikita Vasilyev]

Created attachment 308123 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 308123 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 308123 [details]
Patch

Clearing flags on attachment: 308123

Committed r215757: <http://trac.webkit.org/changeset/215757>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.