Bug 171249 - Allow tabs with capturing audio or video to exceed background CPU limit
Summary: Allow tabs with capturing audio or video to exceed background CPU limit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-24 14:00 PDT by Chris Dumez
Modified: 2017-04-24 16:56 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2017-04-24 14:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-04-24 14:00:13 PDT 
Allow tabs with capturing audio or video to exceed background CPU limit as this is a legit case of potentially high background CPU use.
Comment 1 Chris Dumez 2017-04-24 14:13:09 PDT 
<rdar://problem/31796314>
Comment 2 Chris Dumez 2017-04-24 14:14:40 PDT 
Created attachment 308010 [details]
Patch
Comment 3 Geoffrey Garen 2017-04-24 14:34:45 PDT 
Comment on attachment 308010 [details]
Patch

Did you mean to put this up for review? If so, r=me
Comment 4 Chris Dumez 2017-04-24 15:43:27 PDT 
Committed r215699: <http://trac.webkit.org/changeset/215699>
Comment 5 youenn fablet 2017-04-24 16:56:57 PDT 
Comment on attachment 308010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308010&action=review

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:1177
> +        if (page->hasActiveAudioStream() || page->hasActiveVideoStream()) {

LGTM.
Seeing again the names in this context, something like isCapturingAudio/isCapturingVideo might be clearer than hasActiveVideoStream/hasActiveVideoStream.