Bug 171236 - Relax the event firing ASSERT for Attr changes
Summary: Relax the event firing ASSERT for Attr changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-24 11:48 PDT by Brent Fulgham
Modified: 2017-04-25 19:26 PDT (History)
14 users (show)

See Also:

Attachments
Patch (6.20 KB, patch)
2017-04-25 14:45 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (6.28 KB, patch)
2017-04-25 18:45 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-04-24 11:48:01 PDT 
In Bug 167318 we added assertions to help us recognize when events were being dispatched at inappropriate times. These assertions were overly-strict, and are firing for some cases where we expect events to be triggered.

This Bug relaxes the assertion for the case of an Attribute being modified, which must send style change notifications.
Comment 1 Brent Fulgham 2017-04-24 11:48:12 PDT 
<rdar://problem/30516349>
Comment 2 Brent Fulgham 2017-04-25 14:45:55 PDT 
Created attachment 308148 [details]
Patch
Comment 3 Dean Jackson 2017-04-25 18:43:42 PDT 
Comment on attachment 308148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308148&action=review

> Source/WebCore/dom/ContainerNode.cpp:72
>  #ifndef NDEBUG

You use !ASSERT_DISABLED in the .h file.
Comment 4 Brent Fulgham 2017-04-25 18:45:50 PDT 
Created attachment 308186 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-04-25 19:26:08 PDT 
Comment on attachment 308186 [details]
Patch for landing

Clearing flags on attachment: 308186

Committed r215787: <http://trac.webkit.org/changeset/215787>
Comment 6 WebKit Commit Bot 2017-04-25 19:26:10 PDT 
All reviewed patches have been landed.  Closing bug.