RESOLVED CONFIGURATION CHANGED 171234
REGRESSION (r215620): Multiple worker LayoutTests are flaky timeouts 
https://bugs.webkit.org/show_bug.cgi?id=171234
Summary REGRESSION (r215620): Multiple worker LayoutTests are flaky timeouts
Ryan Haddad
Reported 2017-04-24 11:18:10 PDT
LayoutTest http/tests/websocket/tests/hybi/workers/worker-reload.html is a flaky timeout https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fworkers%2Fworker-reload.html
Attachments
Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2017-04-25 15:52:27 PDT
*** Bug 171237 has been marked as a duplicate of this bug. ***
Ryan Haddad
Comment 2 2017-04-25 15:54:54 PDT
I'm seeing flakiness with the following tests: fast/workers/worker-exception-during-navigation.html http/tests/websocket/tests/hybi/workers/worker-reload.html fetch/fetch-worker-crash.html All of them seem are timing out very frequently after http://trac.webkit.org/changeset/215620. I cannot reproduce the timeouts with r215619.
Ryan Haddad
Comment 3 2017-04-25 16:00:23 PDT
Same goes for fast/workers/worker-exception-during-navigation.html
Ryan Haddad
Comment 4 2017-04-25 16:01:10 PDT
(In reply to Ryan Haddad from comment #3) > Same goes for fast/workers/worker-exception-during-navigation.html Heh, I already pasted that one in comment 2.
Radar WebKit Bug Importer
Comment 5 2017-04-25 18:51:41 PDT
<rdar://problem/31827333>
Ryan Haddad
Comment 6 2017-04-25 20:32:44 PDT
I think we should roll out this change (or rather, changes) because of its impact on tests. It isn't immediately clear what changes need to go, since it was rolled out and back in once already.
Ryan Haddad
Comment 7 2017-04-25 20:54:19 PDT
(In reply to Ryan Haddad from comment #6) > I think we should roll out this change (or rather, changes) because of its > impact on tests. It isn't immediately clear what changes need to go, since > it was rolled out and back in once already. I did some digging and I now see that there have been follow-up fixes that stop this from being a clean revert.
Alexey Proskuryakov
Comment 8 2017-04-26 09:16:50 PDT
I wonder if Yusuke fixed this in bug 171319.
Matt Lewis
Comment 9 2017-04-26 10:34:06 PDT
(In reply to Alexey Proskuryakov from comment #8) > I wonder if Yusuke fixed this in bug 171319. After 3 builds, looks like http/tests/websocket/tests/hybi/workers/worker-reload.html isn't flaky but will keep a watch on it.
Matt Lewis
Comment 10 2017-04-26 12:37:43 PDT
Checked the flakinesses dashboard for all test mentioned in this bug. Issue seems to be resolved.
Note You need to log in before you can comment on or make changes to this bug.