[GTK] Libgcrypt warning: missing initialization - please fix the application

[Carlos Alberto Lopez Perez]

When running the WebKitGTK+ layout tests, the following warning appears on /var/log/user.log

   WebKitWebProcess: Libgcrypt warning: missing initialization - please fix the application

[Michael Catanzaro]

I think the original warning was fixed in bug #173589.

But now we have a new one:

Sep 01 08:57:53 victory-road WebKitNetworkProcess[20806]: Libgcrypt warning: missing initialization - please fix the application

Seems like it's needed in network process too.

[Zan Dobersek]

Most likely this is occurring due to PAL::CryptoDigest use in SoupNetworkSession.

[Zan Dobersek]

Created attachment 319718 [details]
Patch

[Michael Catanzaro]

Comment on attachment 319718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319718&action=review

Thanks!

> Source/WebKit/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:56
> +#if USE(GCRYPT)
> +    // Call gcry_check_version() before any other libgcrypt call, ignoring the
> +    // returned version string.
> +    gcry_check_version(nullptr);
> +
> +    // Pre-allocate 16kB of secure memory and finish the initialization.
> +    gcry_control(GCRYCTL_INIT_SECMEM, 16384, nullptr);
> +    gcry_control(GCRYCTL_INITIALIZATION_FINISHED, nullptr);
> +#endif

We should move this down to PAL so we don't have to duplicate it in multiple places. Probably time to add a Source/WebCore/PAL/pal/crypto/gcrypt/Utilities.cpp.

[Zan Dobersek]

Created attachment 319737 [details]
Patch

[Michael Catanzaro]

Thanks. Please add it to https://trac.webkit.org/wiki/WebKitGTK/2.18.x after you land it.

[Zan Dobersek]

Comment on attachment 319737 [details]
Patch

Clearing flags on attachment: 319737

Committed r221572: <http://trac.webkit.org/changeset/221572>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.