Bug 171229 - [GTK] Missing plural strings
Summary: [GTK] Missing plural strings
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-04-24 09:59 PDT by Piotr Drąg
Modified: 2017-04-24 10:43 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Drąg 2017-04-24 09:59:47 PDT
Following strings from LocalizedStrings.cpp need proper plurals handling, similarly to what "Use at least one character"/"Use at least %d characters" and "Use no more than one character"/"Use no more than %d characters" from the same file have:

"%d files"
"%s %d×%d pixels"
"%1$d days %2$d hours %3$d minutes %4$d seconds"
"%1$d hours %2$d minutes %3$d seconds"
"%1$d minutes %2$d seconds"
"%1$d seconds"
"Use at least %d characters"
"Use no more than %d characters"

The time strings probably need to be split to pluralize correctly.

Some general info on the topic: https://wiki.gnome.org/TranslationProject/DevGuidelines/Plurals
Comment 1 Piotr Drąg 2017-04-24 10:43:00 PDT
(Actually, the strings already using ngettext are in LocalizedStringsGtk.cpp, not LocalizedStrings.cpp.)