[GCrypt] RSAES-PKCS1-v1_5 support
Created attachment 307970 [details] Patch Still has to enable the relevant layout tests.
Attachment 307970 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:126: CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:153: CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 308231 [details] Patch
Attachment 308231 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:126: CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:153: CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 308231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308231&action=review I'm surprised that WebKit supports so many crypto algorithms that are not part of the WebCryto standard. I know this is permitted, it's just unusual. Anyway, thanks for bringing us up to feature parity with the Mac port. As with all these WebCrypto patches, you should try to get a review from Jiewen as well. > Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:88 > + // Return MPI data of the embedded a integer. This comment is missing something!
(In reply to Michael Catanzaro from comment #5) > Comment on attachment 308231 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308231&action=review > > I'm surprised that WebKit supports so many crypto algorithms that are not > part of the WebCryto standard. I know this is permitted, it's just unusual. > Anyway, thanks for bringing us up to feature parity with the Mac port. > We should review what we want to support -- whether we want to follow the spec closely, or whether we're fine with supporting other algorithms as well. For instance, I think AES_CFB has been dropped from the spec, and we might not want to support it since there's been no release of libgcrypt yet that we could use to support that algorithm. > As with all these WebCrypto patches, you should try to get a review from > Jiewen as well. > > > Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:88 > > + // Return MPI data of the embedded a integer. > > This comment is missing something! The integer is actually named as `a`. I should add quotations.
Comment on attachment 308231 [details] Patch Looks good to me as well.
Committed r217546: <http://trac.webkit.org/changeset/217546>
<rdar://problem/32479867>