Bug 171191 - Address some FIXMEs in JavaScript tests for bugs that have been fixed
Summary: Address some FIXMEs in JavaScript tests for bugs that have been fixed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-23 00:03 PDT by Joseph Pecoraro
Modified: 2017-04-24 11:09 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (5.69 KB, patch)
2017-04-23 00:04 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (117.73 KB, patch)
2017-04-23 00:13 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-04-23 00:03:42 PDT 
Address some FIXMEs in JavaScript tests for bugs that have been fixed
Comment 1 Joseph Pecoraro 2017-04-23 00:04:31 PDT 
Created attachment 307922 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2017-04-23 00:13:40 PDT 
Created attachment 307924 [details]
[PATCH] Proposed Fix

Fixed style issues. Good for review.
Comment 3 Saam Barati 2017-04-23 09:54:14 PDT 
Comment on attachment 307924 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2017-04-23 10:23:07 PDT 
Comment on attachment 307924 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 307924

Committed r215674: <http://trac.webkit.org/changeset/215674>
Comment 5 WebKit Commit Bot 2017-04-23 10:23:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2017-04-23 22:49:42 PDT 
Reopening the bug and correcting the patch that is up for review. I put a different bug's patch on here by mistake. Original patch still reviewable.
Comment 7 JF Bastien 2017-04-24 09:36:38 PDT 
Comment on attachment 307922 [details]
[PATCH] Proposed Fix

r=me
Comment 8 WebKit Commit Bot 2017-04-24 11:09:00 PDT 
Comment on attachment 307922 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 307922

Committed r215688: <http://trac.webkit.org/changeset/215688>
Comment 9 WebKit Commit Bot 2017-04-24 11:09:44 PDT 
All reviewed patches have been landed.  Closing bug.