RESOLVED WONTFIX 17118
kjs_navigator.cpp should be re-written to be less crazy 
https://bugs.webkit.org/show_bug.cgi?id=17118
Summary kjs_navigator.cpp should be re-written to be less crazy
Eric Seidel (no email)
Reported 2008-01-31 09:13:49 PST
kjs_navigator.cpp should be re-written to be less crazy kjs_navigator uses a complicated/hacky memory management scheme and thus I bet leaks in some cases. Better would be for PluginBase to hold a reference to some PluginInfoCache static. When the PluginInfoCache ref count drops to 0, it can clear its caches. Those caches can use Vector<OwnPtr> to avoid ever leaking. This could/should also be re-written to use the bindings autogen system. Thus Navigator would become a normal RefCounted class, and Navigator.idl would take care of all the details.
Attachments
Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2009-01-02 11:30:10 PST
Can this bug be closed? I know Navigator.h/cpp/idl were created a while ago, and the plugin code has undergone many refactorings since this was filed.
Note You need to log in before you can comment on or make changes to this bug.