Bug 171176 – [ATK] atk_table_cell_get_position() should return values of aria-rowindex and aria-colindex, if present

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

For ATK, support for aria-rowindex and aria-colindex requires:
1. Expose the values via the "rowindex" and "colindex" object attributes
2. Returning the values via atk_table_cell_get_position()

See:
* https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaColIndex
* https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaRowIndex

[Radar WebKit Bug Importer]

<rdar://problem/31775666>

[Joanmarie Diggs]

Updating the summary because the object attributes are already done.

[Joanmarie Diggs]

Created attachment 321851 [details]
Patch

[chris fleizach]

Comment on attachment 321851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321851&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:126
> +            rowIndex = columnRowRange.first;

this should be columRowRange.second right?

[Joanmarie Diggs]

(In reply to chris fleizach from comment #4)
> Comment on attachment 321851 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321851&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:126
> > +            rowIndex = columnRowRange.first;
> 
> this should be columRowRange.second right?

The index/location is the range's first; the span/length is its second.

[WebKit Commit Bot]

Comment on attachment 321851 [details]
Patch

Clearing flags on attachment: 321851

Committed r222551: <http://trac.webkit.org/changeset/222551>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.