Bug 171175 – [ATK] Expose value of aria-keyshortcuts as object attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaKeyshortcuts

[Radar WebKit Bug Importer]

<rdar://problem/31775615>

[Joanmarie Diggs]

Created attachment 323384 [details]
Patch

[chris fleizach]

Comment on attachment 323384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323384&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:605
> +    String keyShortcuts = coreObject->getAttribute(HTMLNames::aria_keyshortcutsAttr);

can we plumb this through AccessibilityObject?

[Joanmarie Diggs]

(In reply to chris fleizach from comment #3)
> Comment on attachment 323384 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=323384&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:605
> > +    String keyShortcuts = coreObject->getAttribute(HTMLNames::aria_keyshortcutsAttr);
> 
> can we plumb this through AccessibilityObject?

We could. But I was going for the minimal amount of change given what was stated in bug 159215 (i.e. doubts about what support for this new ARIA feature would entail).

If we do add support in AccessibilityObject, should we just return the value as-is, or convert it to a Vector as was done for AccessibilityRenderObject::determineARIADropEffects()?

[chris fleizach]

Comment on attachment 323384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323384&action=review

>>> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:605
>>> +    String keyShortcuts = coreObject->getAttribute(HTMLNames::aria_keyshortcutsAttr);
>> 
>> can we plumb this through AccessibilityObject?
> 
> We could. But I was going for the minimal amount of change given what was stated in bug 159215 (i.e. doubts about what support for this new ARIA feature would entail).
> 
> If we do add support in AccessibilityObject, should we just return the value as-is, or convert it to a Vector as was done for AccessibilityRenderObject::determineARIADropEffects()?

I think probably just a pass through for the time being

[Joanmarie Diggs]

Created attachment 323397 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 323397 [details]
Patch

Clearing flags on attachment: 323397

Committed r223190: <https://trac.webkit.org/changeset/223190>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.