1. atk_table_get_n_rows() and atk_table_get_n_columns() 2. "rowcount" and "colcount" object attributes
<rdar://problem/31775527>
Updating the summary because the object attributes are already done.
Created attachment 321216 [details] Patch
Comment on attachment 321216 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321216&action=review > LayoutTests/platform/gtk/accessibility/aria-table-attributes-expected.txt:8 > +FAIL grid.rowCount should be 4. Was 30. is it expected these are failures?
(In reply to chris fleizach from comment #4) > Comment on attachment 321216 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321216&action=review > > > LayoutTests/platform/gtk/accessibility/aria-table-attributes-expected.txt:8 > > +FAIL grid.rowCount should be 4. Was 30. > > is it expected these are failures? Ugh. The updated value is right -- and not a failure. shouldBe() in tests will be the death of me.... Will do a new patch in a little while. Sorry for missing that and thanks for the review!
Created attachment 321326 [details] Patch
Comment on attachment 321326 [details] Patch Attachment 321326 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4605342 New failing tests: fast/images/animated-gif-webkit-transform.html
Created attachment 321337 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 321326 [details] Patch (In reply to Build Bot from comment #7) > Comment on attachment 321326 [details] > Patch > > Attachment 321326 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.webkit.org/results/4605342 > > New failing tests: > fast/images/animated-gif-webkit-transform.html I'm failing to understand how a change made in the ATK (WebKitGtk accessibility) code could cause a non-accessibility test for macOS to fail. If my patch is really to blame, hints/insight shall be gratefully accepted. In the meantime, since the one shared accessibility test I tweaked is not showing up as a failure in macOS, setting r? and clearing the cq-.
Comment on attachment 321326 [details] Patch Clearing flags on attachment: 321326 Committed r222276: <http://trac.webkit.org/changeset/222276>
All reviewed patches have been landed. Closing bug.