Bug 171170 – [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

As per https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#role-map-treegrid

[Radar WebKit Bug Importer]

<rdar://problem/31775028>

[Joanmarie Diggs]

Created attachment 308674 [details]
Patch

[chris fleizach]

Comment on attachment 308674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308674&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:650
> +            case TreeGridRole:

will need to update this method too

- (AccessibilityObjectWrapper*)_accessibilityTableAncestor
{
    
    if (const AccessibilityObject* parent = AccessibilityObject::matchedParent(*m_object, false, [] (const AccessibilityObject& object) {
        return object.roleValue() == TableRole || object.roleValue() == GridRole;
    }))
        return parent->wrapper();
    return nil;
}

[Joanmarie Diggs]

Comment on attachment 308674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308674&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:581
> +        return object.isTable();

Chris: Isn't the above the change you're asking me to make in your review? Otherwise, I'm suffering from grepfail.

>> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:650
>> +            case TreeGridRole:
> 
> will need to update this method too
> 
> - (AccessibilityObjectWrapper*)_accessibilityTableAncestor
> {
>     
>     if (const AccessibilityObject* parent = AccessibilityObject::matchedParent(*m_object, false, [] (const AccessibilityObject& object) {
>         return object.roleValue() == TableRole || object.roleValue() == GridRole;
>     }))
>         return parent->wrapper();
>     return nil;
> }

Please see above (I think I already did).

[chris fleizach]

Comment on attachment 308674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308674&action=review

>> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:581
>> +        return object.isTable();
> 
> Chris: Isn't the above the change you're asking me to make in your review? Otherwise, I'm suffering from grepfail.

ah sorry!

[WebKit Commit Bot]

Comment on attachment 308674 [details]
Patch

Clearing flags on attachment: 308674

Committed r215988: <http://trac.webkit.org/changeset/215988>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.