RESOLVED FIXED 171166
AX: Update implementation of aria-orientation 
https://bugs.webkit.org/show_bug.cgi?id=171166
Summary AX: Update implementation of aria-orientation
Joanmarie Diggs
Reported 2017-04-22 11:09:44 PDT
In ARIA 1.1, aria-orientation was added to the following roles with the specified implicit values: * combobox: undefined * listbox: vertical * menu: vertical * menubar: horizontal * radiogroup: undefined * tablist: horizontal * toolbar: horizontal * tree: vertical * treegrid: undefined In ARIA 1.1, the following changes related to aria-orientation were also made: * aria-orientation's default value changed from horizontal to undefined * separator now has implicit value of horizontal * slider now has implicit value of horizontal I am seeing failures both in Safari and WebKitGtk, e.g. combobox, radiogroup, slider, and treegrid. We should fix those, and also ensure we have layout test(s) covering all roles that support aria-orientation.
Attachments
Patch (21.03 KB, patch)
2017-05-02 11:32 PDT, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-04-22 11:10:12 PDT
<rdar://problem/31774741>
Joanmarie Diggs
Comment 2 2017-05-02 11:32:33 PDT
Created attachment 308838 [details] Patch
WebKit Commit Bot
Comment 3 2017-05-02 13:07:19 PDT
Comment on attachment 308838 [details] Patch Clearing flags on attachment: 308838 Committed r216089: <http://trac.webkit.org/changeset/216089>
WebKit Commit Bot
Comment 4 2017-05-02 13:07:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.