Bug 171160 - test262: test262/test/language/statements/for-of/dstr-array-elem-init-fn-name-arrow.js
Summary: test262: test262/test/language/statements/for-of/dstr-array-elem-init-fn-name...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-22 01:12 PDT by Joseph Pecoraro
Modified: 2017-04-24 11:00 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (24.13 KB, patch)
2017-04-22 01:15 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (846.99 KB, application/zip)
2017-04-22 03:32 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-04-22 01:12:20 PDT
test262/test/language/statements/for-of/dstr-array-elem-init-fn-name-arrow.js

Test:

    for ([ arrow = ()=>{} ] of [[]])
        assert(arrow.name === "arrow");

Notes:
- This is a default value assignment in destructuring where the function and name are known statically but we aren't linking them up
- We are just missing a place where we can infer the name in our pattern detection!
- Chrome passes, Firefox doesn't
Comment 1 Joseph Pecoraro 2017-04-22 01:15:45 PDT
Created attachment 307901 [details]
[PATCH] Proposed Fix
Comment 2 Build Bot 2017-04-22 03:32:21 PDT
Comment on attachment 307901 [details]
[PATCH] Proposed Fix

Attachment 307901 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3583340

New failing tests:
compositing/absolute-inside-out-of-view-fixed.html
Comment 3 Build Bot 2017-04-22 03:32:22 PDT
Created attachment 307903 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 4 JF Bastien 2017-04-24 09:34:37 PDT
Comment on attachment 307901 [details]
[PATCH] Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2017-04-24 10:59:53 PDT
Comment on attachment 307901 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 307901

Committed r215687: <http://trac.webkit.org/changeset/215687>
Comment 6 WebKit Commit Bot 2017-04-24 11:00:15 PDT
All reviewed patches have been landed.  Closing bug.