Bug 171146 - [MediaCapture] Improvements to CoreAudioCaptureSource
Summary: [MediaCapture] Improvements to CoreAudioCaptureSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-21 15:22 PDT by Jer Noble
Modified: 2017-05-01 08:48 PDT (History)
4 users (show)

See Also:

Attachments
Patch (13.65 KB, patch)
2017-04-21 15:30 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (11.02 KB, patch)
2017-04-21 15:38 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (11.02 KB, patch)
2017-04-21 16:18 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (11.02 KB, patch)
2017-04-21 16:20 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (13.21 KB, patch)
2017-04-21 16:41 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for Landing (13.25 KB, patch)
2017-04-21 17:25 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-04-21 15:22:50 PDT 
[MediaCapture] Improvements to CoreAudioCaptureSource
Comment 1 Jer Noble 2017-04-21 15:30:50 PDT 
Created attachment 307819 [details]
Patch
Comment 2 Jer Noble 2017-04-21 15:38:07 PDT 
Created attachment 307820 [details]
Patch
Comment 3 Jer Noble 2017-04-21 16:18:57 PDT 
Created attachment 307826 [details]
Patch
Comment 4 Jer Noble 2017-04-21 16:20:54 PDT 
Created attachment 307827 [details]
Patch
Comment 5 Jer Noble 2017-04-21 16:41:27 PDT 
Created attachment 307837 [details]
Patch
Comment 6 Eric Carlson 2017-04-21 16:54:48 PDT 
Comment on attachment 307837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307837&action=review

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:402
> +    uint32_t propertySize = sizeof(m_captureDeviceID);

Does this work in a 32-bit build?

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:550
> +    m_currentSettings = std::nullopt;

This should call the base class method so it notifies observers.
Comment 7 Radar WebKit Bug Importer 2017-04-21 16:55:45 PDT 
<rdar://problem/31769428>
Comment 8 Jer Noble 2017-04-21 17:22:19 PDT 
(In reply to Eric Carlson from comment #6)
> Comment on attachment 307837 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=307837&action=review
> 
> > Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:402
> > +    uint32_t propertySize = sizeof(m_captureDeviceID);
> 
> Does this work in a 32-bit build?

It should, since we use this pattern in other places in this file.

> > Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:550
> > +    m_currentSettings = std::nullopt;
> 
> This should call the base class method so it notifies observers.

Good catch!
Comment 9 Jer Noble 2017-04-21 17:25:54 PDT 
Created attachment 307845 [details]
Patch for Landing
Comment 10 Jer Noble 2017-04-21 18:00:20 PDT 
Committed r215659: <http://trac.webkit.org/changeset/215659>