WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
171146
[MediaCapture] Improvements to CoreAudioCaptureSource
https://bugs.webkit.org/show_bug.cgi?id=171146
Summary
[MediaCapture] Improvements to CoreAudioCaptureSource
Jer Noble
Reported
2017-04-21 15:22:50 PDT
[MediaCapture] Improvements to CoreAudioCaptureSource
Attachments
Patch
(13.65 KB, patch)
2017-04-21 15:30 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(11.02 KB, patch)
2017-04-21 15:38 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(11.02 KB, patch)
2017-04-21 16:18 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(11.02 KB, patch)
2017-04-21 16:20 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(13.21 KB, patch)
2017-04-21 16:41 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch for Landing
(13.25 KB, patch)
2017-04-21 17:25 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Jer Noble
Comment 1
2017-04-21 15:30:50 PDT
Created
attachment 307819
[details]
Patch
Jer Noble
Comment 2
2017-04-21 15:38:07 PDT
Created
attachment 307820
[details]
Patch
Jer Noble
Comment 3
2017-04-21 16:18:57 PDT
Created
attachment 307826
[details]
Patch
Jer Noble
Comment 4
2017-04-21 16:20:54 PDT
Created
attachment 307827
[details]
Patch
Jer Noble
Comment 5
2017-04-21 16:41:27 PDT
Created
attachment 307837
[details]
Patch
Eric Carlson
Comment 6
2017-04-21 16:54:48 PDT
Comment on
attachment 307837
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=307837&action=review
> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:402 > + uint32_t propertySize = sizeof(m_captureDeviceID);
Does this work in a 32-bit build?
> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:550 > + m_currentSettings = std::nullopt;
This should call the base class method so it notifies observers.
Radar WebKit Bug Importer
Comment 7
2017-04-21 16:55:45 PDT
<
rdar://problem/31769428
>
Jer Noble
Comment 8
2017-04-21 17:22:19 PDT
(In reply to Eric Carlson from
comment #6
)
> Comment on
attachment 307837
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=307837&action=review
> > > Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:402 > > + uint32_t propertySize = sizeof(m_captureDeviceID); > > Does this work in a 32-bit build?
It should, since we use this pattern in other places in this file.
> > Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:550 > > + m_currentSettings = std::nullopt; > > This should call the base class method so it notifies observers.
Good catch!
Jer Noble
Comment 9
2017-04-21 17:25:54 PDT
Created
attachment 307845
[details]
Patch for Landing
Jer Noble
Comment 10
2017-04-21 18:00:20 PDT
Committed
r215659
: <
http://trac.webkit.org/changeset/215659
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug