Bug 171144 - Follow up with SharedBuffer changes after r215608
Summary: Follow up with SharedBuffer changes after r215608
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-21 15:13 PDT by Alex Christensen
Modified: 2017-04-24 10:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (24.53 KB, patch)
2017-04-21 15:22 PDT, Alex Christensen 		ggaren: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-04-21 15:13:37 PDT 
Follow up with SharedBuffer changes after r215608
Comment 1 Alex Christensen 2017-04-21 15:22:58 PDT 
Created attachment 307817 [details]
Patch
Comment 2 Geoffrey Garen 2017-04-21 15:58:55 PDT 
Comment on attachment 307817 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-04-21 20:07:18 PDT 
Comment on attachment 307817 [details]
Patch

Rejecting attachment 307817 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 307817, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
.mm
Hunk #1 FAILED at 180.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm.rej
patching file Source/WebCore/xml/XMLHttpRequest.cpp
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Geoffrey Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3581192
Comment 4 Alex Christensen 2017-04-24 10:39:28 PDT 
I just incorporated these changes into the latest version of https://bugs.webkit.org/show_bug.cgi?id=170956