RESOLVED INVALID 171135
Fix Atomics for pointers 
https://bugs.webkit.org/show_bug.cgi?id=171135
Summary Fix Atomics for pointers
Keith Miller
Reported 2017-04-21 13:14:49 PDT
Fix Atomics for pointers
Attachments
Patch (1.58 KB, patch)
2017-04-21 13:15 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-04-21 13:15:03 PDT
Created attachment 307783 [details] Patch
Keith Miller
Comment 2 2017-04-21 13:16:05 PDT
I get this error though: /Volumes/Data/ws4/OpenSource/Source/WTF/wtf/Atomics.h:247:73: error: return type of out-of-line definition of 'WTF::Atomic::loadLink' differs from that in the declaration ALWAYS_INLINE std::enable_if_t<std::is_pointer<T>::value, T> Atomic<T>::loadLink(std::memory_order order) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ /Volumes/Data/ws4/OpenSource/Source/WTF/wtf/Atomics.h:122:21: note: previous declaration is here ALWAYS_INLINE T loadLink(std::memory_order order = std::memory_order_seq_cst); ~ ^
Sam Weinig
Comment 3 2017-04-21 13:24:53 PDT
Comment on attachment 307783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307783&action=review > Source/WTF/ChangeLog:9 > + * wtf/Atomics.h: > + (WTF::Atomic<T>::loadLink): Please add a description.
Keith Miller
Comment 4 2017-04-21 13:58:38 PDT
I'm going to fix this issue by just removing the LL SC stuff it wasn't a progression anyway according to pizlo.
Note You need to log in before you can comment on or make changes to this bug.