Bug 171124 - Make AudioSampleBufferList::reset() less expensive.
Summary: Make AudioSampleBufferList::reset() less expensive.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-21 11:24 PDT by Jer Noble
Modified: 2017-04-21 12:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.08 KB, patch)
2017-04-21 11:28 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (10.09 KB, patch)
2017-04-21 11:44 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-04-21 11:24:38 PDT 
Make AudioSampleBufferList::reset() less expensive.
Comment 1 Jer Noble 2017-04-21 11:28:58 PDT 
Created attachment 307757 [details]
Patch
Comment 2 Eric Carlson 2017-04-21 11:31:36 PDT 
Comment on attachment 307757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307757&action=review

> Source/WebCore/platform/audio/WebAudioBufferList.cpp:45
> +    m_pristineList = std::unique_ptr<AudioBufferList>(static_cast<AudioBufferList*>(::operator new (m_listBufferSize)));

Nit: maybe m_canonicalList?
Comment 3 Jer Noble 2017-04-21 11:44:47 PDT 
Created attachment 307761 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-04-21 12:22:50 PDT 
Comment on attachment 307761 [details]
Patch for landing

Clearing flags on attachment: 307761

Committed r215624: <http://trac.webkit.org/changeset/215624>