Bug 171118 - X86-64 assembler doesn't handle xchg with byte register src
Summary: X86-64 assembler doesn't handle xchg with byte register src
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-21 10:29 PDT by Michael Saboff
Modified: 2017-04-21 11:28 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2017-04-21 10:38 PDT, Michael Saboff
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2017-04-21 10:29:50 PDT
The Intel manual Vol 2A 3-3 shows that byte registers SPL and greater require a REX prefix byte.  The is done with the X86Assembler function oneByteOp8().  Use of that function was omitted when the xchg8_*() functions was added.
Comment 1 Radar WebKit Bug Importer 2017-04-21 10:32:14 PDT
<rdar://problem/31760529>
Comment 2 Michael Saboff 2017-04-21 10:38:51 PDT
Created attachment 307746 [details]
Patch

I did verify that all other byte ops use the *Op8() formatter function.
Comment 3 Michael Saboff 2017-04-21 10:42:33 PDT
I fixed the spelling in the bug title, including the ChangeLog.
Comment 4 Michael Saboff 2017-04-21 11:28:53 PDT
Committed r215618: <http://trac.webkit.org/changeset/215618>