Bug 171095 - [MediaCapture][iOS] AVAudioSession must be active and the correct category before IO AudioUnits start producing data.
Summary: [MediaCapture][iOS] AVAudioSession must be active and the correct category be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on: 171168
Blocks:
  Show dependency tree / graph
 
Reported: 2017-04-20 19:08 PDT by Jer Noble
Modified: 2017-04-22 11:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.92 KB, patch)
2017-04-20 19:19 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-04-20 19:08:44 PDT 
[MediaCapture][iOS] AVAudioSession must be active and the correct category before IO AudioUnits start producing data.
Comment 1 Jer Noble 2017-04-20 19:19:25 PDT 
Created attachment 307681 [details]
Patch
Comment 2 youenn fablet 2017-04-20 20:11:20 PDT 
Comment on attachment 307681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307681&action=review

> Source/WebCore/Modules/mediastream/MediaStream.cpp:448
> +    if (m_private->hasAudio() && m_isProducingData && m_private->hasCaptureAudioSource())

It would seem logic to have m_private->hasAudio() if m_private->hasCaptureAudioSource().
Is there a redundant check?
Comment 3 WebKit Commit Bot 2017-04-21 12:59:10 PDT 
Comment on attachment 307681 [details]
Patch

Clearing flags on attachment: 307681

Committed r215626: <http://trac.webkit.org/changeset/215626>
Comment 4 WebKit Commit Bot 2017-04-21 12:59:12 PDT 
All reviewed patches have been landed.  Closing bug.