Bug 171088 – Update the MASM probe to only take 1 arg instead of 2 (in addition to the callback function).

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Experience shows that we never use the 2nd arg.  So, let's remove it to reduce the footprint at each probe site.

Also fix the MacroAssembler::print() function so that it is a no-op when !ENABLE(MASM_PROBE).  This will allow us to have print() statements in JIT code without a lot of #if ENABLE(MASM_PROBE)s later.

[Mark Lam]

Created attachment 307660 [details]
proposed patch.

[Mark Lam]

I've done builds for ARMv7, ARM64, x86, and x86_64 with this patch, and ran a smoke test of printing something using the MASM print.

I also did a build with !ENABLE(MASM_PROBE) to confirm that MASM print becomes a no-op in that case.

[Michael Saboff]

Comment on attachment 307660 [details]
proposed patch.

r=me

[Saam Barati]

r=me too

[Mark Lam]

Thanks for the reviews.  Landed in r215592: <http://trac.webkit.org/r215592>.

[Ryan Haddad]

(In reply to Mark Lam from comment #5)
> Thanks for the reviews.  Landed in r215592: <http://trac.webkit.org/r215592>.

This change appears to have broken the CLoop build:

https://build.webkit.org/builders/Apple%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/1009

[Mark Lam]

(In reply to Ryan Haddad from comment #6)
> (In reply to Mark Lam from comment #5)
> > Thanks for the reviews.  Landed in r215592: <http://trac.webkit.org/r215592>.
> 
> This change appears to have broken the CLoop build:
> 
> https://build.webkit.org/builders/
> Apple%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/1009

Build fix for this landed in r215595: <http://trac.webkit.org/r215595>.