Bug 171083 - Try to make API test WebKit2.OpenAndCloseWindowAsyncCallbackException bulletproof
Summary: Try to make API test WebKit2.OpenAndCloseWindowAsyncCallbackException bulletp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-20 15:43 PDT by Brady Eidson
Modified: 2017-04-20 16:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.35 KB, patch)
2017-04-20 15:45 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-04-20 15:43:25 PDT 
Try to make API test WebKit2.OpenAndCloseWindowAsyncCallbackException bulletproof

Failing on the bots (but not locally; story of our lives), so I'm skipping for now.

Would be nice to get it working.
Comment 1 Brady Eidson 2017-04-20 15:45:34 PDT 
For the record:

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/822
The failure that the Sierra Release Build API bot is seeing:

...
PASS WebKit2.OpenAndCloseWindowAsync
UNEXPECTEDLY EXITED WebKit2.OpenAndCloseWindowAsyncCallbackException
2017-04-20 15:17:34.466 TestWebKitAPI[1427:18965497] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Completion handler passed to -[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:] was not called'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff9c71062b __exceptionPreprocess + 171
	1   libobjc.A.dylib                     0x00007fffb1ac71da objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff9c78dc55 +[NSException raise:format:] + 197
	3   WebKit                              0x00000001058ab0b5 _ZN6WebKit28CompletionHandlerCallCheckerD2Ev + 129
	4   WebKit                              0x00000001058fa014 _ZNK3WTF20ThreadSafeRefCountedIN6WebKit28CompletionHandlerCallCheckerEE5derefEv + 36
	5   WebKit                              0x00000001059ce396 _ZZN3WTF8BlockPtrIFvP9WKWebViewEE12fromCallableIZN6WebKit10UIDelegate8UIClient19createNewPageCommonEPNS6_12WebPageProxyEPNS6_13WebFrameProxyERKN7WebCore18SecurityOriginDataERKNSD_15ResourceRequestERKNSD_14WindowFeaturesERKNS6_20NavigationActionDataEPNSt3__18functionIFvNS_6RefPtrIS9_EEEEEE3$_0EES4_T_ENUlPKvE_8__invokeES10_ + 54
	6   libsystem_blocks.dylib              0x00007fffb23dc952 _Block_release + 102
	7   TestWebKitAPI                       0x00000001042eb80f -[OpenAndCloseWindowUIDelegateAsync dealloc] + 36
	8   TestWebKitAPI                       0x00000001042ebda9 _ZN53WebKit2_OpenAndCloseWindowAsyncCallbackException_Test8TestBodyEv + 437
	9   TestWebKitAPI                       0x00000001043bb4a4 _ZN7testing4Test3RunEv + 92
	10  TestWebKitAPI                       0x00000001043bbcfe _ZN7testing8internal12TestInfoImpl3RunEv + 180
	11  TestWebKitAPI                       0x00000001043bc0dd _ZN7testing8TestCase3RunEv + 191
	12  TestWebKitAPI                       0x00000001043bf6a3 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 595
	13  TestWebKitAPI                       0x0000000104323126 _ZN13TestWebKitAPI15TestsController3runEiPPc + 120
	14  TestWebKitAPI                       0x0000000104399b55 main + 344
	15  libdyld.dylib                       0x00007fffb23a8235 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
Comment 2 Brady Eidson 2017-04-20 15:45:59 PDT 
Created attachment 307652 [details]
Patch
Comment 3 Build Bot 2017-04-20 15:48:07 PDT 
Attachment 307652 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:140:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:141:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:169:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2017-04-20 16:27:20 PDT 
Comment on attachment 307652 [details]
Patch

Clearing flags on attachment: 307652

Committed r215586: <http://trac.webkit.org/changeset/215586>
Comment 5 WebKit Commit Bot 2017-04-20 16:27:21 PDT 
All reviewed patches have been landed.  Closing bug.