Bug 171081 - -[WKUIDelegatePrivate _webView:requestUserMediaAuthorizationForMicrophone:camera:url:mainFrameURL:decisionHandler:] decision handler should only have one parameter.
Summary: -[WKUIDelegatePrivate _webView:requestUserMediaAuthorizationForMicrophone:cam...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-20 15:38 PDT by Andrew Gold
Modified: 2017-04-21 18:36 PDT (History)
8 users (show)

See Also:

Attachments
Proposed patch. (7.67 KB, patch)
2017-04-20 18:11 PDT, Andrew Gold 		no flags Details | Formatted Diff | Diff
proposed patch v2. (9.36 KB, patch)
2017-04-20 18:33 PDT, Andrew Gold 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gold 2017-04-20 15:38:39 PDT 
Since user media authorization is all or nothing (we will not authorize access to just one device if multiple are requested), the decision handler should only have one parameter.
Comment 1 Andrew Gold 2017-04-20 18:11:00 PDT 
Created attachment 307670 [details]
Proposed patch.
Comment 2 Build Bot 2017-04-20 18:13:21 PDT 
Attachment 307670 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:56:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andrew Gold 2017-04-20 18:33:02 PDT 
Created attachment 307672 [details]
proposed patch v2.
Comment 4 Build Bot 2017-04-20 18:35:15 PDT 
Attachment 307672 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:56:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2017-04-21 11:33:01 PDT 
Comment on attachment 307672 [details]
proposed patch v2.

Clearing flags on attachment: 307672

Committed r215619: <http://trac.webkit.org/changeset/215619>
Comment 6 WebKit Commit Bot 2017-04-21 11:33:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-04-21 18:36:13 PDT 
<rdar://problem/31770580>