Bug 171056 – Enable CoreAudioCaptureSource testing

• Status: NEW
• Component: Media

[youenn fablet]

There are no regression testing nor ASAN checks done when CoreAudioCaptureSource is active. This is a problem especially now that it can be used in the UIProcess

[youenn fablet]

In addition to unit test, one possibility is to use CoreAudioCaptureSource in LayoutTests whenever we do not expect a specific audio signal.
Tests doing getUserMedia without web audio could use CoreAudioCaptureSource.

[Eric Carlson]

(In reply to youenn fablet from comment #1)
> In addition to unit test, one possibility is to use CoreAudioCaptureSource
> in LayoutTests whenever we do not expect a specific audio signal.
> Tests doing getUserMedia without web audio could use CoreAudioCaptureSource.

I don't think we can guarantee that all machines running layout tests have audio capture hardware.

[youenn fablet]

Ideas envisioned:
- Add virtual drivers for mic and cameras so that the regular capture source code could be used but would serve mock data. This would probably replace mock sources that may be part of WebRTC WebDriver integration
- Have dedicated bots with mic/camera that would be used to run specific layout tests/api tests dedicated to media.

[Radar WebKit Bug Importer]

<rdar://problem/32321847>

[youenn fablet]

Created attachment 311018 [details]
Patch

[youenn fablet]

Created attachment 311019 [details]
Patch

[Build Bot]

Attachment 311019 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h:43:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.