Bug 171056 - Enable CoreAudioCaptureSource testing
Summary: Enable CoreAudioCaptureSource testing
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-20 07:55 PDT by youenn fablet
Modified: 2017-05-23 09:19 PDT (History)
7 users (show)

See Also:


Attachments
Patch (97.83 KB, patch)
2017-05-23 09:13 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (94.28 KB, patch)
2017-05-23 09:16 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-04-20 07:55:27 PDT
There are no regression testing nor ASAN checks done when CoreAudioCaptureSource is active. This is a problem especially now that it can be used in the UIProcess
Comment 1 youenn fablet 2017-04-20 07:58:59 PDT
In addition to unit test, one possibility is to use CoreAudioCaptureSource in LayoutTests whenever we do not expect a specific audio signal.
Tests doing getUserMedia without web audio could use CoreAudioCaptureSource.
Comment 2 Eric Carlson 2017-04-20 08:17:32 PDT
(In reply to youenn fablet from comment #1)
> In addition to unit test, one possibility is to use CoreAudioCaptureSource
> in LayoutTests whenever we do not expect a specific audio signal.
> Tests doing getUserMedia without web audio could use CoreAudioCaptureSource.

I don't think we can guarantee that all machines running layout tests have audio capture hardware.
Comment 3 youenn fablet 2017-04-20 20:34:18 PDT
Ideas envisioned:
- Add virtual drivers for mic and cameras so that the regular capture source code could be used but would serve mock data. This would probably replace mock sources that may be part of WebRTC WebDriver integration
- Have dedicated bots with mic/camera that would be used to run specific layout tests/api tests dedicated to media.
Comment 4 Radar WebKit Bug Importer 2017-05-22 00:29:23 PDT
<rdar://problem/32321847>
Comment 5 youenn fablet 2017-05-23 09:13:54 PDT
Created attachment 311018 [details]
Patch
Comment 6 youenn fablet 2017-05-23 09:16:31 PDT
Created attachment 311019 [details]
Patch
Comment 7 Build Bot 2017-05-23 09:19:54 PDT
Attachment 311019 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h:43:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.