Bug 171040 – AX: FKA: Buttons need a visible focus indicator

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Aaron Chu]

<rdar://problem/30922548>

[Aaron Chu]

Created attachment 307554 [details]
Patch

[Build Bot]

Comment on attachment 307554 [details]
Patch

Attachment 307554 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3568052

New failing tests:
media/modern-media-controls/icon-button/icon-button-focus-state.html

[Build Bot]

Created attachment 307562 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Aaron Chu]

Created attachment 307568 [details]
Patch

[Antoine Quint]

What happens when a button in the "on" state, such as the AirPlay button when playing the media through AirPlay, is also focused?

[Aaron Chu]

It seems the existing "-apple-wireless-playback-target-active" is still used. Is the AirPlay button the only one that has an active state? I would like to suggest considering using the "active" state as the "on" state. When active (pressed), the button turns white, and so if the click persists it is reasonable for it to remain its background color (white), which can free up the blue to be used as focus state.

Perhaps this is something we can consult HI?

[James Craig]

(In reply to Aaron Chu from comment #6)

> Perhaps this is something we can consult HI?

Let's get it in working order so that HI has something to try out in the builds. If someone want additional changes, those can be in a follow-up bug. Let's don't gate the core functionality on a potential review that may be delayed.

[Aaron Chu]

Created attachment 307805 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 307805 [details]
Patch

Clearing flags on attachment: 307805

Committed r215652: <http://trac.webkit.org/changeset/215652>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Aaron Chu]

This seems no longer exist anymore in the code base.

[Aaron Chu]

Created attachment 316659 [details]
Patch

[Build Bot]

Comment on attachment 316659 [details]
Patch

Attachment 316659 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4203895

New failing tests:
media/modern-media-controls/button/button-focus-state.html

[Build Bot]

Created attachment 316668 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 316659 [details]
Patch

Attachment 316659 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4203919

New failing tests:
media/modern-media-controls/button/button-focus-state.html

[Build Bot]

Created attachment 316670 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Aaron Chu]

Created attachment 316678 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 316678 [details]
Patch

Clearing flags on attachment: 316678

Committed r220041: <http://trac.webkit.org/changeset/220041>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.