Bug 171036 - Update pip placard to "picture in picture"
Summary: Update pip placard to "picture in picture"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media Elements (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-19 21:47 PDT by Jon Lee
Modified: 2017-04-20 10:53 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.37 KB, patch)
2017-04-19 21:55 PDT, Jon Lee
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (893.29 KB, application/zip)
2017-04-19 23:06 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.65 MB, application/zip)
2017-04-19 23:20 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (841.15 KB, application/zip)
2017-04-20 00:14 PDT, Build Bot
no flags Details
Patch (4.97 KB, patch)
2017-04-20 00:39 PDT, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (7.11 KB, patch)
2017-04-20 01:12 PDT, Jon Lee
graouts: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2017-04-19 21:47:23 PDT
Update pip placard to "picture in picture"

rdar://problem/30201536
Comment 1 Jon Lee 2017-04-19 21:55:46 PDT
Created attachment 307552 [details]
Patch
Comment 2 Build Bot 2017-04-19 23:06:31 PDT
Comment on attachment 307552 [details]
Patch

Attachment 307552 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3568008

New failing tests:
media/modern-media-controls/pip-placard/pip-placard.html
Comment 3 Build Bot 2017-04-19 23:06:32 PDT
Created attachment 307560 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-04-19 23:20:25 PDT
Comment on attachment 307552 [details]
Patch

Attachment 307552 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3568026

New failing tests:
media/modern-media-controls/pip-placard/pip-placard.html
Comment 5 Build Bot 2017-04-19 23:20:26 PDT
Created attachment 307561 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-04-20 00:14:38 PDT
Comment on attachment 307552 [details]
Patch

Attachment 307552 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3568144

New failing tests:
media/modern-media-controls/pip-placard/pip-placard.html
Comment 7 Build Bot 2017-04-20 00:14:40 PDT
Created attachment 307569 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 8 Jon Lee 2017-04-20 00:39:00 PDT
Created attachment 307573 [details]
Patch
Comment 9 Jon Lee 2017-04-20 01:12:29 PDT
Created attachment 307577 [details]
Patch
Comment 10 Jon Lee 2017-04-20 10:53:20 PDT
Committed r215564: <http://trac.webkit.org/changeset/215564>