Bug 171033 - Remove WebKitTestRunner code for enabling features that are already enabled by default
Summary: Remove WebKitTestRunner code for enabling features that are already enabled b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-19 20:02 PDT by Joseph Pecoraro
Modified: 2017-04-19 22:26 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (8.23 KB, patch)
2017-04-19 20:02 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-04-19 20:02:10 PDT 
Remove WebKitTestRunner code for enabling features that are already enabled by default.

Here are the easy ones:

    ShadowDOM
    CustomElements
    DownloadAttribute
    FetchAPI

Others might be possible but these seem straightforward.
Comment 1 Joseph Pecoraro 2017-04-19 20:02:50 PDT 
Created attachment 307544 [details]
[PATCH] Proposed Fix
Comment 2 Ryosuke Niwa 2017-04-19 20:06:01 PDT 
Comment on attachment 307544 [details]
[PATCH] Proposed Fix

r=me assuming tests pass everywhere.
Comment 3 Joseph Pecoraro 2017-04-19 21:58:30 PDT 
Comment on attachment 307544 [details]
[PATCH] Proposed Fix

As best as I can tell this patch did not cause the Mac WK1 errors as this doesn't change WebKit1 behavior at all. cq+
Comment 4 WebKit Commit Bot 2017-04-19 22:26:55 PDT 
Comment on attachment 307544 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 307544

Committed r215552: <http://trac.webkit.org/changeset/215552>
Comment 5 WebKit Commit Bot 2017-04-19 22:26:56 PDT 
All reviewed patches have been landed.  Closing bug.