Bug 171032 - Support calc() in font-variation-settings and font-feature-settings
Summary: Support calc() in font-variation-settings and font-feature-settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 162815
  Show dependency tree / graph
 
Reported: 2017-04-19 19:31 PDT by Myles C. Maxfield
Modified: 2017-05-22 23:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.19 KB, patch)
2017-05-22 14:09 PDT, Myles C. Maxfield 		hyatt: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.73 MB, application/zip)
2017-05-22 15:06 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.52 MB, application/zip)
2017-05-22 15:13 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (4.10 MB, application/zip)
2017-05-22 15:15 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews117 for mac-elcapitan (2.54 MB, application/zip)
2017-05-22 15:19 PDT, Build Bot 		no flags Details
Patch for committing (6.39 KB, patch)
2017-05-22 16:54 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-04-19 19:31:06 PDT 
Make sure calc() works with font-variation-settings
Comment 1 Myles C. Maxfield 2017-05-22 14:09:09 PDT 
Created attachment 310917 [details]
Patch
Comment 2 Dave Hyatt 2017-05-22 14:12:08 PDT 
Comment on attachment 310917 [details]
Patch

r=me
Comment 3 Build Bot 2017-05-22 15:06:56 PDT 
Comment on attachment 310917 [details]
Patch

Attachment 310917 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3796251

New failing tests:
css3/font-feature-settings-parsing.html
fast/text/font-face-javascript.html
fast/css/inherited-properties-rare-text.html
Comment 4 Build Bot 2017-05-22 15:06:58 PDT 
Created attachment 310930 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-05-22 15:13:14 PDT 
Comment on attachment 310917 [details]
Patch

Attachment 310917 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3796265

New failing tests:
css3/font-feature-settings-parsing.html
fast/text/font-face-javascript.html
fast/css/inherited-properties-rare-text.html
Comment 6 Build Bot 2017-05-22 15:13:16 PDT 
Created attachment 310932 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-05-22 15:15:41 PDT 
Comment on attachment 310917 [details]
Patch

Attachment 310917 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3796178

New failing tests:
css3/font-feature-settings-parsing.html
fast/text/font-face-javascript.html
fast/css/inherited-properties-rare-text.html
Comment 8 Build Bot 2017-05-22 15:15:43 PDT 
Created attachment 310934 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-05-22 15:19:15 PDT 
Comment on attachment 310917 [details]
Patch

Attachment 310917 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3796180

New failing tests:
css3/font-feature-settings-parsing.html
fast/text/font-face-javascript.html
fast/css/inherited-properties-rare-text.html
Comment 10 Build Bot 2017-05-22 15:19:16 PDT 
Created attachment 310935 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Myles C. Maxfield 2017-05-22 16:54:50 PDT 
Created attachment 310957 [details]
Patch for committing
Comment 12 Myles C. Maxfield 2017-05-22 23:03:34 PDT 
Committed r217267: <http://trac.webkit.org/changeset/217267>