Bug 171002 - REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed
Summary: REGRESSION (r213168): An extra Web Content process is spun up on launch and i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-19 12:23 PDT by Brady Eidson
Modified: 2017-04-19 15:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.02 KB, patch)
2017-04-19 12:26 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (11.04 KB, patch)
2017-04-19 13:05 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-04-19 12:23:55 PDT 
REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed

This happens in Safari and any other app that calls [WKProcessPool _warmInitialProcess]

<rdar://problem/30774839>
Comment 1 Brady Eidson 2017-04-19 12:26:58 PDT 
Created attachment 307496 [details]
Patch
Comment 2 Alex Christensen 2017-04-19 12:40:51 PDT 
Comment on attachment 307496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307496&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm:51
> +    EXPECT_EQ([pool _webProcessCount], (size_t)1);

Do 1u, 1ull, or static_cast<size_t>(1) work?  I don't like this c-style cast.
Comment 3 Brady Eidson 2017-04-19 13:05:09 PDT 
Created attachment 307500 [details]
Patch
Comment 4 WebKit Commit Bot 2017-04-19 15:43:52 PDT 
Comment on attachment 307500 [details]
Patch

Clearing flags on attachment: 307500

Committed r215536: <http://trac.webkit.org/changeset/215536>
Comment 5 WebKit Commit Bot 2017-04-19 15:43:54 PDT 
All reviewed patches have been landed.  Closing bug.