Bug 171001 - Another deadlock in CoreAudioCaptureSource
Summary: Another deadlock in CoreAudioCaptureSource
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media Elements (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-19 11:30 PDT by Eric Carlson
Modified: 2017-04-20 15:29 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch. (6.23 KB, patch)
2017-04-19 11:38 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch for landing. (6.21 KB, patch)
2017-04-19 12:49 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2017-04-19 11:30:00 PDT
Fix deadlock in CoreAudioCaptureSource and address comments missed in the review of bug 170771.
Comment 1 Radar WebKit Bug Importer 2017-04-19 11:31:39 PDT
<rdar://problem/31712568>
Comment 2 Eric Carlson 2017-04-19 11:38:18 PDT
Created attachment 307494 [details]
Proposed patch.
Comment 3 youenn fablet 2017-04-19 12:21:00 PDT
Comment on attachment 307494 [details]
Proposed patch.

r=me with small change discussed directly
Comment 4 Eric Carlson 2017-04-19 12:49:12 PDT
Created attachment 307499 [details]
Patch for landing.
Comment 5 WebKit Commit Bot 2017-04-19 13:43:04 PDT
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, mitz@webkit.org, rniwa@webkit.org, and tonyg@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2017-04-19 13:43:05 PDT
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2017-04-19 14:24:23 PDT
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html bug 168317 (author: graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2017-04-19 14:24:24 PDT
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2017-04-19 15:05:53 PDT
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2017-04-19 15:05:54 PDT
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2017-04-19 16:36:39 PDT
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2017-04-19 16:36:58 PDT
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2017-04-19 17:53:40 PDT
Comment on attachment 307499 [details]
Patch for landing.

Clearing flags on attachment: 307499

Committed r215546: <http://trac.webkit.org/changeset/215546>