Bug 170977 – [GTK] Web Inspector: some SVG images are specified 'currentColor' incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Fujii Hironori]

[GTK] Web Inspector: some SVG images are specified 'currentColor' incorrectly

The keyword 'currentColor' is specifed manually in Bug 150602.
But, some SVG images are specified unexpectedly.

  gtk/NavigationItemCurleyBraces.svg
  gtk/NavigationItemTypes.svg
  gtk/UpDownArrows.svg

And, gtk/NavigationItemCurleyBraces.svg is licensed under NonCommercial CC (Bug 170902).
I'll recreate this image.

[Fujii Hironori]

Created attachment 307452 [details]
Patch

[Fujii Hironori]

Created attachment 307455 [details]
A screenshot of before and after

[Michael Catanzaro]

Could you please split this into two patches:

 * First patch to fix currentColor
 * Second patch, in bug #170902, to replace gtk/NavigationItemCurleyBraces.svg with the new version created by you.

Thanks a bunch for fixing these issues. Also thanks for the screenshot, as that makes reviewing it much easier.

[Fujii Hironori]

Created attachment 307553 [details]
Patch

Sure.

[Joseph Pecoraro]

Comment on attachment 307553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307553&action=review

> Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemCurleyBraces.svg:-2
> -<!-- Licensed under the Creative Commons Attribution-Share Alike 3.0 United States License (http://creativecommons.org/licenses/by-sa/3.0/) -->

This removes the license that all the others have. Unexpected?

[Fujii Hironori]

Umm, I should address Bug 170902 before this?
Any idea, Michael?

[Michael Catanzaro]

Please use CC-BY-SA for your new image, yes. And let's land a patch for that image in bug #170902 instead, yes. We shouldn't bury the fix for that in this issue. Perhaps you could upload a new patch here with the changes to just the other two icons.

[Fujii Hironori]

Created attachment 308333 [details]
Patch

[Fujii Hironori]

Created attachment 308336 [details]
screenshot of before and after this fix

[WebKit Commit Bot]

Comment on attachment 308333 [details]
Patch

Clearing flags on attachment: 308333

Committed r215867: <http://trac.webkit.org/changeset/215867>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.