Bug 170972 - Move notFound into its own file
Summary: Move notFound into its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-18 17:58 PDT by Sam Weinig
Modified: 2017-04-20 12:44 PDT (History)
9 users (show)

See Also:


Attachments
Patch (7.36 KB, patch)
2017-04-18 18:09 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-04-18 17:58:30 PDT
Move notFound into its own file
Comment 1 Sam Weinig 2017-04-18 18:09:52 PDT
Created attachment 307445 [details]
Patch
Comment 2 WebKit Commit Bot 2017-04-19 10:57:56 PDT
Comment on attachment 307445 [details]
Patch

Clearing flags on attachment: 307445

Committed r215518: <http://trac.webkit.org/changeset/215518>
Comment 3 WebKit Commit Bot 2017-04-19 10:57:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Ryan Haddad 2017-04-19 15:05:30 PDT
This change appears to have broken the Windows build:

c:\cygwin\home\buildbot\slave\win-debug\build\source\wtf\wtf\Vector.h(50): error C2953: 'WTF::VectorDestructor<false,T>': class template has already been defined (compiling source file C:\cygwin\home\buildbot\slave\win-debug\build\Source\WTF\wtf\ParkingLot.cpp) [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\WTF\wtf\WTF.vcxproj]


https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/692/steps/compile-webkit/logs/stdio
Comment 5 Ryan Haddad 2017-04-19 15:07:02 PDT
Reverted r215518 for reason:

This change appears to have broken the Windows build.

Committed r215534: <http://trac.webkit.org/changeset/215534>
Comment 6 Joseph Pecoraro 2017-04-19 16:30:37 PDT
(In reply to Ryan Haddad from comment #4)
> This change appears to have broken the Windows build:
> 
> c:\cygwin\home\buildbot\slave\win-debug\build\source\wtf\wtf\Vector.h(50):
> error C2953: 'WTF::VectorDestructor<false,T>': class template has already
> been defined (compiling source file

My guess is this is from moving to #pragma once and ForwardingHeaders. We've seen this before.
Comment 7 Sam Weinig 2017-04-20 12:44:34 PDT
Re-landed in r215571 without pragma changes.