Bug 170968 – [WK2] Cannot select text on nytimes.com when the selection granularity is WKSelectionGranularityCharacter

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

0. Enable selection granularity character by default via Safari internal settings
1. Go to nytimes.com
2. Go to any article
3. Long press to try and select a word

Observed: the selection does not change.
Expected: the word should be selected.

Not a regression.

[Wenson Hsieh]

<rdar://problem/31692560>

[Wenson Hsieh]

Created attachment 307425 [details]
Patch

Comment on attachment 307425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307425&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1532
> +    // If we're current editing an assisted node, only allow the selection to move within that assisted node.

currently?

[Wenson Hsieh]

Comment on attachment 307425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307425&action=review

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1532
>> +    // If we're current editing an assisted node, only allow the selection to move within that assisted node.
> 
> currently?

Good catch! Fixed.

[Wenson Hsieh]

Created attachment 307426 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 307426 [details]
Patch for landing

Clearing flags on attachment: 307426

Committed r215484: <http://trac.webkit.org/changeset/215484>

[Build Bot]

Comment on attachment 307425 [details]
Patch

Attachment 307425 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3559617

New failing tests:
webrtc/captureCanvas-webrtc.html

[Build Bot]

Created attachment 307438 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6