Currently it is not passed to libwebrtc
Created attachment 307414 [details] Patch
Comment on attachment 307414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307414&action=review > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:67 > + void doCreateOffer(const RTCOfferOptions&); Would it make sense to pass a RTCOfferOptions&& to mirror the parameter type in LibWebRTCPeerConnectionBackend::doCreateOffer?
And do we want to add values for the other values in RTCOfferAnswerOptions to RTCOfferOptions? This adds use of ice_restart and we have unused voice_activity_detection, but use_rtp_mux and offer_to_receive_video and offer_to_receive_audio are unmentioned in WebCore.
Comment on attachment 307414 [details] Patch Attachment 307414 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3559202 New failing tests: fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html fast/mediastream/RTCPeerConnection-inspect-offer.html fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html fast/mediastream/RTCPeerConnection-inspect-answer.html fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html webrtc/libwebrtc/release-while-setting-local-description.html fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html
Created attachment 307424 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 307414 [details] Patch Attachment 307414 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3559227 New failing tests: webrtc/libwebrtc/release-while-setting-local-description.html
Created attachment 307428 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Thanks for the review. (In reply to Alex Christensen from comment #3) > And do we want to add values for the other values in RTCOfferAnswerOptions > to RTCOfferOptions? This adds use of ice_restart and we have unused > voice_activity_detection, but use_rtp_mux and offer_to_receive_video and > offer_to_receive_audio are unmentioned in WebCore. We should add voiceActivityDetection as well. Other values are legacy options, whose functionality should be implemented through transceivers (though we do not support enough of transceivers yet to handle these). (In reply to Alex Christensen from comment #2) > View in context: > https://bugs.webkit.org/attachment.cgi?id=307414&action=review > > > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:67 > > + void doCreateOffer(const RTCOfferOptions&); > > Would it make sense to pass a RTCOfferOptions&& to mirror the parameter type > in LibWebRTCPeerConnectionBackend::doCreateOffer? I am not sure. Since there is no point in moving any value in RTCOfferOptions, it is just best to use a "const RTCOfferOptions&" in the whole call flow.
Created attachment 307440 [details] Patch for landing
Comment on attachment 307440 [details] Patch for landing Rejecting attachment 307440 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 307440, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp patching file Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h patching file Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp patching file Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp patching file Source/WebCore/testing/MockLibWebRTCPeerConnection.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3559867
Created attachment 307457 [details] Patch for landing
Comment on attachment 307457 [details] Patch for landing Clearing flags on attachment: 307457 Committed r215501: <http://trac.webkit.org/changeset/215501>
All reviewed patches have been landed. Closing bug.