Bug 170966 - RTCOfferOptions iceRestart should be supported
Summary: RTCOfferOptions iceRestart should be supported
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media Elements (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-18 14:00 PDT by youenn fablet
Modified: 2017-04-18 21:01 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.96 KB, patch)
2017-04-18 14:01 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.67 MB, application/zip)
2017-04-18 15:25 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (23.27 MB, application/zip)
2017-04-18 15:41 PDT, Build Bot
no flags Details
Patch for landing (6.99 KB, patch)
2017-04-18 17:18 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (6.76 KB, patch)
2017-04-18 20:18 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-04-18 14:00:11 PDT
Currently it is not passed to libwebrtc
Comment 1 youenn fablet 2017-04-18 14:01:52 PDT
Created attachment 307414 [details]
Patch
Comment 2 Alex Christensen 2017-04-18 15:19:54 PDT
Comment on attachment 307414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307414&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:67
> +    void doCreateOffer(const RTCOfferOptions&);

Would it make sense to pass a RTCOfferOptions&& to mirror the parameter type in LibWebRTCPeerConnectionBackend::doCreateOffer?
Comment 3 Alex Christensen 2017-04-18 15:22:07 PDT
And do we want to add values for the other values in RTCOfferAnswerOptions to RTCOfferOptions?  This adds use of ice_restart and we have unused voice_activity_detection, but use_rtp_mux and offer_to_receive_video and offer_to_receive_audio are unmentioned in WebCore.
Comment 4 Build Bot 2017-04-18 15:25:45 PDT
Comment on attachment 307414 [details]
Patch

Attachment 307414 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3559202

New failing tests:
fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html
fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html
fast/mediastream/RTCPeerConnection-inspect-offer.html
fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html
fast/mediastream/RTCPeerConnection-inspect-answer.html
fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html
fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html
webrtc/libwebrtc/release-while-setting-local-description.html
fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html
Comment 5 Build Bot 2017-04-18 15:25:46 PDT
Created attachment 307424 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-04-18 15:41:28 PDT
Comment on attachment 307414 [details]
Patch

Attachment 307414 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3559227

New failing tests:
webrtc/libwebrtc/release-while-setting-local-description.html
Comment 7 Build Bot 2017-04-18 15:41:30 PDT
Created attachment 307428 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 8 youenn fablet 2017-04-18 16:11:43 PDT
Thanks for the review.

(In reply to Alex Christensen from comment #3)
> And do we want to add values for the other values in RTCOfferAnswerOptions
> to RTCOfferOptions?  This adds use of ice_restart and we have unused
> voice_activity_detection, but use_rtp_mux and offer_to_receive_video and
> offer_to_receive_audio are unmentioned in WebCore.

We should add voiceActivityDetection as well.
Other values are legacy options, whose functionality should be implemented through transceivers (though we do not support enough of transceivers yet to handle these).

(In reply to Alex Christensen from comment #2)

> View in context:
> https://bugs.webkit.org/attachment.cgi?id=307414&action=review
> 
> > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:67
> > +    void doCreateOffer(const RTCOfferOptions&);
> 
> Would it make sense to pass a RTCOfferOptions&& to mirror the parameter type
> in LibWebRTCPeerConnectionBackend::doCreateOffer?

I am not sure.
Since there is no point in moving any value in RTCOfferOptions, it is just best to use a "const RTCOfferOptions&" in the whole call flow.
Comment 9 youenn fablet 2017-04-18 17:18:57 PDT
Created attachment 307440 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2017-04-18 17:19:41 PDT
Comment on attachment 307440 [details]
Patch for landing

Rejecting attachment 307440 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 307440, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
patching file Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h
patching file Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
patching file Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp
patching file Source/WebCore/testing/MockLibWebRTCPeerConnection.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3559867
Comment 11 youenn fablet 2017-04-18 20:18:54 PDT
Created attachment 307457 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2017-04-18 21:01:52 PDT
Comment on attachment 307457 [details]
Patch for landing

Clearing flags on attachment: 307457

Committed r215501: <http://trac.webkit.org/changeset/215501>
Comment 13 WebKit Commit Bot 2017-04-18 21:01:53 PDT
All reviewed patches have been landed.  Closing bug.