Bug 170958 - wasm/function-tests/memory-multiagent times out sometimes
Summary: wasm/function-tests/memory-multiagent times out sometimes
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-18 11:41 PDT by Filip Pizlo
Modified: 2017-04-18 13:19 PDT (History)
2 users (show)

See Also:


Attachments
patch to skip the test for now (2.45 KB, patch)
2017-04-18 11:42 PDT, Filip Pizlo
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-04-18 11:41:33 PDT
...
Comment 1 Filip Pizlo 2017-04-18 11:42:57 PDT
Created attachment 307399 [details]
patch to skip the test for now
Comment 2 Keith Miller 2017-04-18 11:48:40 PDT
Comment on attachment 307399 [details]
patch to skip the test for now

r=me.
Comment 3 Keith Miller 2017-04-18 11:48:57 PDT
Comment on attachment 307399 [details]
patch to skip the test for now

View in context: https://bugs.webkit.org/attachment.cgi?id=307399&action=review

> JSTests/wasm/function-tests/memory-multiagent.js:51
> +        // prevents any JS-heap-modifying things from happening because JS is a synchrinous

typo: synchronous
Comment 4 Filip Pizlo 2017-04-18 11:50:16 PDT
(In reply to Keith Miller from comment #3)
> Comment on attachment 307399 [details]
> patch to skip the test for now
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=307399&action=review
> 
> > JSTests/wasm/function-tests/memory-multiagent.js:51
> > +        // prevents any JS-heap-modifying things from happening because JS is a synchrinous
> 
> typo: synchronous

Fixed!
Comment 5 Filip Pizlo 2017-04-18 12:28:47 PDT
Landed in https://trac.webkit.org/changeset/215475/webkit
Comment 6 JF Bastien 2017-04-18 13:13:51 PDT
Comment on attachment 307399 [details]
patch to skip the test for now

View in context: https://bugs.webkit.org/attachment.cgi?id=307399&action=review

> JSTests/wasm/function-tests/memory-multiagent.js:53
> +        // https://bugs.webkit.org/show_bug.cgi?id=170958

My expectation was that receiveBroadcast could change the value of `state`. Is that not the case?
Comment 7 Filip Pizlo 2017-04-18 13:16:47 PDT
(In reply to JF Bastien from comment #6)
> Comment on attachment 307399 [details]
> patch to skip the test for now
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=307399&action=review
> 
> > JSTests/wasm/function-tests/memory-multiagent.js:53
> > +        // https://bugs.webkit.org/show_bug.cgi?id=170958
> 
> My expectation was that receiveBroadcast could change the value of `state`.
> Is that not the case?

It could.  But how would it run?  JS is runloop-based.  You're doing a while loop.  So the runloop doesn't run.
Comment 8 JF Bastien 2017-04-18 13:19:52 PDT
(In reply to Filip Pizlo from comment #7)
> (In reply to JF Bastien from comment #6)
> > Comment on attachment 307399 [details]
> > patch to skip the test for now
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=307399&action=review
> > 
> > > JSTests/wasm/function-tests/memory-multiagent.js:53
> > > +        // https://bugs.webkit.org/show_bug.cgi?id=170958
> > 
> > My expectation was that receiveBroadcast could change the value of `state`.
> > Is that not the case?
> 
> It could.  But how would it run?  JS is runloop-based.  You're doing a while
> loop.  So the runloop doesn't run.

Seemed to work in the jsc shell. I'll do a follow-up soon.