...
Created attachment 307399 [details] patch to skip the test for now
Comment on attachment 307399 [details] patch to skip the test for now r=me.
Comment on attachment 307399 [details] patch to skip the test for now View in context: https://bugs.webkit.org/attachment.cgi?id=307399&action=review > JSTests/wasm/function-tests/memory-multiagent.js:51 > + // prevents any JS-heap-modifying things from happening because JS is a synchrinous typo: synchronous
(In reply to Keith Miller from comment #3) > Comment on attachment 307399 [details] > patch to skip the test for now > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307399&action=review > > > JSTests/wasm/function-tests/memory-multiagent.js:51 > > + // prevents any JS-heap-modifying things from happening because JS is a synchrinous > > typo: synchronous Fixed!
Landed in https://trac.webkit.org/changeset/215475/webkit
Comment on attachment 307399 [details] patch to skip the test for now View in context: https://bugs.webkit.org/attachment.cgi?id=307399&action=review > JSTests/wasm/function-tests/memory-multiagent.js:53 > + // https://bugs.webkit.org/show_bug.cgi?id=170958 My expectation was that receiveBroadcast could change the value of `state`. Is that not the case?
(In reply to JF Bastien from comment #6) > Comment on attachment 307399 [details] > patch to skip the test for now > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307399&action=review > > > JSTests/wasm/function-tests/memory-multiagent.js:53 > > + // https://bugs.webkit.org/show_bug.cgi?id=170958 > > My expectation was that receiveBroadcast could change the value of `state`. > Is that not the case? It could. But how would it run? JS is runloop-based. You're doing a while loop. So the runloop doesn't run.
(In reply to Filip Pizlo from comment #7) > (In reply to JF Bastien from comment #6) > > Comment on attachment 307399 [details] > > patch to skip the test for now > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=307399&action=review > > > > > JSTests/wasm/function-tests/memory-multiagent.js:53 > > > + // https://bugs.webkit.org/show_bug.cgi?id=170958 > > > > My expectation was that receiveBroadcast could change the value of `state`. > > Is that not the case? > > It could. But how would it run? JS is runloop-based. You're doing a while > loop. So the runloop doesn't run. Seemed to work in the jsc shell. I'll do a follow-up soon.