This piece was missing from https://bugs.webkit.org/show_bug.cgi?id=170883
Created attachment 307392 [details] Patch
Created attachment 307394 [details] Patch
Comment on attachment 307394 [details] Patch Attachment 307394 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3558439 New failing tests: webrtc/captureCanvas-webrtc.html
Created attachment 307400 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 307394 [details] Patch Attachment 307394 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3558455 New failing tests: webrtc/release-after-getting-track.html webrtc/ephemeral-certificates-and-cnames.html webrtc/video-addTrack.html webrtc/video-with-receiver.html webrtc/video-disabled-black.html webrtc/video-remote-mute.html webrtc/libwebrtc/descriptionGetters.html webrtc/captureCanvas-webrtc.html webrtc/video-with-data-channel.html
Created attachment 307401 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 307403 [details] Patch
Crashes are probably due to libwebrtc not defining NDEBUG while WebCore does. Then classes from libwebrtc included/instantiated within WebCore no longer have the same definition, size...
Created attachment 307405 [details] Patch
Comment on attachment 307405 [details] Patch Attachment 307405 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3559120 New failing tests: http/tests/inspector/network/resource-sizes-network.html
Created attachment 307420 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 307405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307405&action=review I like this. Let's split it up and do it cleanly. > Source/WebCore/ChangeLog:10 > + * platform/mediastream/libwebrtc/VideoToolBoxEncoderFactory.cpp: This change is not in this patch. > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:75 > +DEAD_CODE_STRIPPING_normal = YES; This cuts almost 1MB of code from release libwebrtc.dylib! > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc:40 > - return new H264VideoToolboxEncoder(codec); > + return CreateSupportedVideoEncoder(codec); This change is unrelated to the rest of the changes in this patch. The other changes should be in a separate patch titled something like "Strip dead code from release libwebrtc.dylib"
(In reply to Alex Christensen from comment #12) > Comment on attachment 307405 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307405&action=review > > I like this. Let's split it up and do it cleanly. > > > Source/WebCore/ChangeLog:10 > > + * platform/mediastream/libwebrtc/VideoToolBoxEncoderFactory.cpp: > > This change is not in this patch. > > > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:75 > > +DEAD_CODE_STRIPPING_normal = YES; > > This cuts almost 1MB of code from release libwebrtc.dylib! > > > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc:40 > > - return new H264VideoToolboxEncoder(codec); > > + return CreateSupportedVideoEncoder(codec); > > This change is unrelated to the rest of the changes in this patch. The > other changes should be in a separate patch titled something like "Strip > dead code from release libwebrtc.dylib" Well, this change was triggering crashes. The fact that it no longer crashes on EWS show that we have a fix there. OK to split it now that the fix is validated.
Created attachment 307435 [details] Patch
Comment on attachment 307435 [details] Patch Clearing flags on attachment: 307435 Committed r215494: <http://trac.webkit.org/changeset/215494>
All reviewed patches have been landed. Closing bug.