Bug 170941 - Update ANGLE
Summary: Update ANGLE
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Blocks: 170980
  Show dependency treegraph
Reported: 2017-04-18 04:17 PDT by Dean Jackson
Modified: 2017-04-19 00:56 PDT (History)
2 users (show)

See Also:

Patch (9.50 MB, patch)
2017-04-18 04:26 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (9.42 MB, patch)
2017-04-18 04:46 PDT, Dean Jackson
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-04-18 04:17:39 PDT
Update ANGLE
Comment 1 Dean Jackson 2017-04-18 04:18:12 PDT
Comment 2 Dean Jackson 2017-04-18 04:26:16 PDT
Created attachment 307371 [details]
Comment 3 Dean Jackson 2017-04-18 04:28:06 PDT
This first patch won't build. The CMake files are wrong.
Comment 4 Dean Jackson 2017-04-18 04:46:07 PDT
Created attachment 307372 [details]
Comment 5 Alex Christensen 2017-04-18 09:29:32 PDT
Comment on attachment 307372 [details]

WebCore changes are just changing ShSomething to sh::Something.  Straightforward.
The EGL and GLESv2 soft linking was only helping people distributing WinCairo and not wanting to distribute libGLESv2.dll and libEGL.dll, which I think is nobody.  If somebody wants to do that, they can bring the soft linking back.
It looks like ANGLE now includes an Xcode build in the file you included as Source/ThirdParty/ANGLE/src/angle.xcodeproj/project.pbxproj and maybe we could adopt that sometime.  Let's assume no until we find a benefit of doing so.
The Apple-added comments in ExpressionParser.cpp, glslang_tab.cpp, and glslang_tab.h remain.
Comment 6 Dean Jackson 2017-04-18 18:13:41 PDT
Committed r215490: <http://trac.webkit.org/changeset/215490>