Bug 170938 - Enable optimized layer flushes on iOS
Summary: Enable optimized layer flushes on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 170851
Blocks:
  Show dependency tree / graph
 
Reported: 2017-04-18 02:47 PDT by Antti Koivisto
Modified: 2017-04-18 10:31 PDT (History)
7 users (show)

See Also:

Attachments
patch (8.92 KB, patch)
2017-04-18 03:08 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (10.59 KB, patch)
2017-04-18 03:12 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (11.40 KB, patch)
2017-04-18 03:21 PDT, Antti Koivisto 		simon.fraser: review+
Details | Formatted Diff | Diff
patch (11.44 KB, patch)
2017-04-18 04:13 PDT, Antti Koivisto 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-elcapitan (1.52 MB, application/zip)
2017-04-18 05:46 PDT, Build Bot 		no flags Details
patch (16.93 KB, patch)
2017-04-18 09:08 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-04-18 02:47:00 PDT 
Don't flush subtrees without changes on iOS either.
Comment 1 Radar WebKit Bug Importer 2017-04-18 02:55:11 PDT 
<rdar://problem/31677395>
Comment 2 Antti Koivisto 2017-04-18 03:08:52 PDT 
Created attachment 307365 [details]
patch
Comment 3 Antti Koivisto 2017-04-18 03:12:19 PDT 
Created attachment 307366 [details]
patch
Comment 4 Antti Koivisto 2017-04-18 03:21:19 PDT 
Created attachment 307367 [details]
patch
Comment 5 Simon Fraser (smfr) 2017-04-18 03:58:50 PDT 
Comment on attachment 307367 [details]
patch

Did layout tests detect the breakage that this is fixing?
Comment 6 Antti Koivisto 2017-04-18 04:08:57 PDT 
No, we seem to have virtually no test coverage for composited scrolling.
Comment 7 Antti Koivisto 2017-04-18 04:13:28 PDT 
Created attachment 307369 [details]
patch
Comment 8 Simon Fraser (smfr) 2017-04-18 04:25:04 PDT 
(In reply to Antti Koivisto from comment #6)
> No, we seem to have virtually no test coverage for composited scrolling.

We should be able to test now with UIScriptController etc. Can you make one to go along with this change?
Comment 9 Antti Koivisto 2017-04-18 05:04:47 PDT 
> We should be able to test now with UIScriptController etc. Can you make one
> to go along with this change?

I can try!
Comment 10 Build Bot 2017-04-18 05:46:18 PDT 
Comment on attachment 307369 [details]
patch

Attachment 307369 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3556887

New failing tests:
http/tests/inspector/network/resource-sizes-network.html
Comment 11 Build Bot 2017-04-18 05:46:20 PDT 
Created attachment 307378 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 12 Antti Koivisto 2017-04-18 09:08:12 PDT 
Created attachment 307388 [details]
patch

Now with test for tile creation in touch overflow scrolling
Comment 13 WebKit Commit Bot 2017-04-18 10:31:24 PDT 
Comment on attachment 307388 [details]
patch

Clearing flags on attachment: 307388

Committed r215469: <http://trac.webkit.org/changeset/215469>
Comment 14 WebKit Commit Bot 2017-04-18 10:31:26 PDT 
All reviewed patches have been landed.  Closing bug.