Bug 170931 - Web Inspector: DOM/XHR breakpoint sections should be collapsed by default
Summary: Web Inspector: DOM/XHR breakpoint sections should be collapsed by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-17 22:25 PDT by Matt Baker
Modified: 2017-04-24 12:48 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.57 KB, patch)
2017-04-17 22:28 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-04-17 22:25:05 PDT
Summary:
DOM/XHR breakpoint sections should be collapsed by default.

I think it makes sense for the DOM Breakpoints section to auto-expand when a breakpoint is added.
Comment 1 Radar WebKit Bug Importer 2017-04-17 22:26:17 PDT
<rdar://problem/31674190>
Comment 2 Matt Baker 2017-04-17 22:28:37 PDT
Created attachment 307342 [details]
Patch
Comment 3 BJ Burg 2017-04-21 10:35:35 PDT
Comment on attachment 307342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307342&action=review

Did you test that this works correctly when reloading and reopening Inspector while the XHR / DOM breakpoint is selected?

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:1156
> +        this._domBreakpointsSection.collapsed = false;

Shouldn't there be a similar line for XHR breakpoints?
Comment 4 Matt Baker 2017-04-21 12:29:41 PDT
Comment on attachment 307342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307342&action=review

>> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:1156
>> +        this._domBreakpointsSection.collapsed = false;
> 
> Shouldn't there be a similar line for XHR breakpoints?

It isn't possible to add an XHR breakpoint without first expanding the section, to reveal the "+" button.
Comment 5 Matt Baker 2017-04-21 12:34:58 PDT
(In reply to Brian Burg from comment #3)
> Comment on attachment 307342 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=307342&action=review
> 
> Did you test that this works correctly when reloading and reopening
> Inspector while the XHR / DOM breakpoint is selected?

Non-script breakpoints don't have their selection restored on reload, since they have no meaningful represented object to show in the Debugger tab.
Comment 6 BJ Burg 2017-04-24 12:18:38 PDT
Comment on attachment 307342 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2017-04-24 12:48:23 PDT
Comment on attachment 307342 [details]
Patch

Clearing flags on attachment: 307342

Committed r215690: <http://trac.webkit.org/changeset/215690>
Comment 8 WebKit Commit Bot 2017-04-24 12:48:25 PDT
All reviewed patches have been landed.  Closing bug.