Bug 170931 – Web Inspector: DOM/XHR breakpoint sections should be collapsed by default

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Summary:
DOM/XHR breakpoint sections should be collapsed by default.

I think it makes sense for the DOM Breakpoints section to auto-expand when a breakpoint is added.

[Radar WebKit Bug Importer]

<rdar://problem/31674190>

[Matt Baker]

Created attachment 307342 [details]
Patch

[Blaze Burg]

Comment on attachment 307342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307342&action=review

Did you test that this works correctly when reloading and reopening Inspector while the XHR / DOM breakpoint is selected?

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:1156
> +        this._domBreakpointsSection.collapsed = false;

Shouldn't there be a similar line for XHR breakpoints?

[Matt Baker]

Comment on attachment 307342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307342&action=review

>> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:1156
>> +        this._domBreakpointsSection.collapsed = false;
> 
> Shouldn't there be a similar line for XHR breakpoints?

It isn't possible to add an XHR breakpoint without first expanding the section, to reveal the "+" button.

[Matt Baker]

(In reply to Brian Burg from comment #3)
> Comment on attachment 307342 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=307342&action=review
> 
> Did you test that this works correctly when reloading and reopening
> Inspector while the XHR / DOM breakpoint is selected?

Non-script breakpoints don't have their selection restored on reload, since they have no meaningful represented object to show in the Debugger tab.

[Blaze Burg]

Comment on attachment 307342 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 307342 [details]
Patch

Clearing flags on attachment: 307342

Committed r215690: <http://trac.webkit.org/changeset/215690>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.