Bug 170930 - Web Inspector: XHR breakpoints shouldn't be cleared from the sidebar on reload
Summary: Web Inspector: XHR breakpoints shouldn't be cleared from the sidebar on reload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-17 22:02 PDT by Matt Baker
Modified: 2017-04-18 11:50 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.49 KB, patch)
2017-04-17 22:05 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-04-17 22:02:16 PDT
Summary:
XHR breakpoints shouldn't be cleared from the sidebar on reload. Unlike other breakpoints, XHR breakpoints are global and should only be detached (removed from the backend) when deleted.
Comment 1 Radar WebKit Bug Importer 2017-04-17 22:03:18 PDT
<rdar://problem/31674009>
Comment 2 Matt Baker 2017-04-17 22:05:48 PDT
Created attachment 307340 [details]
Patch
Comment 3 Joseph Pecoraro 2017-04-18 11:22:26 PDT
Comment on attachment 307340 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-04-18 11:50:24 PDT
Comment on attachment 307340 [details]
Patch

Clearing flags on attachment: 307340

Committed r215473: <http://trac.webkit.org/changeset/215473>
Comment 5 WebKit Commit Bot 2017-04-18 11:50:29 PDT
All reviewed patches have been landed.  Closing bug.