Bug 170916 – Web Inspector: Enabled state of "All Requests" XHR breakpoint not restored correctly

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Summary:
Enabled state of "All Requests" XHR breakpoint not restored correctly. After creating the global breakpoint from the setting value, it should be set on the backend if enabled.

Right now the breakpoint has to be unchecked/checked for the setting to stick.

Steps to Reproduce:
1. Open a page using XHRs
2. Enable the All Requests breakpoint
3. Initiate an XHR
  => Pause
4. Reload Inspector
5. Initiate an XHR
  => No pause

[Matt Baker]

Created attachment 307299 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 307299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307299&action=review

> Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:71
> +            if (!this._allRequestsBreakpoint.disabled)
> +                this._updateXHRBreakpoint(this._allRequestsBreakpoint);

r- I do not think this makes sense in DOMDebuggerManager.

Workers can have "XHR"Breakpoints but they cannot have "DOM"Breakpoints. So I'd expect this in a location that would be compatible with workers.

[Joseph Pecoraro]

Comment on attachment 307299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307299&action=review

>> Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:71
>> +                this._updateXHRBreakpoint(this._allRequestsBreakpoint);
> 
> r- I do not think this makes sense in DOMDebuggerManager.
> 
> Workers can have "XHR"Breakpoints but they cannot have "DOM"Breakpoints. So I'd expect this in a location that would be compatible with workers.

Ahh, okay "DOMDebugger" is what holds all of the Web specific breakpoints (DOM, XHR, eventually Event, Timeouts, etc). I was mistaken.

r=me

[Radar WebKit Bug Importer]

<rdar://problem/31666196>

[WebKit Commit Bot]

Comment on attachment 307299 [details]
Patch

Clearing flags on attachment: 307299

Committed r215435: <http://trac.webkit.org/changeset/215435>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.