Bug 170910 - JSEventListener::m_isolatedWorld should be a Ref
Summary: JSEventListener::m_isolatedWorld should be a Ref
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-17 12:27 PDT by Brent Fulgham
Modified: 2017-04-18 16:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.36 KB, patch)
2017-04-18 14:28 PDT, Brent Fulgham 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-04-17 12:27:54 PDT 
It doesn't seem like m_isolatedWorld can ever be nullptr. We should switch from RefPtr -> Ref so we can catch any cases where this is set improperly.
Comment 1 Radar WebKit Bug Importer 2017-04-18 14:13:52 PDT 
<rdar://problem/31690856>
Comment 2 Brent Fulgham 2017-04-18 14:28:48 PDT 
Created attachment 307417 [details]
Patch
Comment 3 Brent Fulgham 2017-04-18 16:34:19 PDT 
Committed r215487: <http://trac.webkit.org/changeset/215487>