Bug 170894 – RTCPeerConnection addTrack does not require a stream parameter

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

RTCPeerConnection addTrack does not require a stream parameter as per the spec and https://github.com/w3c/webrtc-pc/issues/288

[youenn fablet]

Created attachment 307243 [details]
Patch

[youenn fablet]

(In reply to youenn fablet from comment #1)
> Created attachment 307243 [details]
> Patch

Playing the stream before it gets the second track is changing the results.
Probably worth investigating that further.

[Alex Christensen]

Comment on attachment 307243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307243&action=review

> LayoutTests/webrtc/video-addTrack-expected.txt:10
> +FAIL Testing image result, wait = false The index is not in the allowed range.

Let's make this not say FAIL if it's the intended behavior.

[youenn fablet]

Thanks for the review

(In reply to Alex Christensen from comment #3)
> Comment on attachment 307243 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=307243&action=review
> 
> > LayoutTests/webrtc/video-addTrack-expected.txt:10
> > +FAIL Testing image result, wait = false The index is not in the allowed range.
> 
> Let's make this not say FAIL if it's the intended 

Will need to check with Eric but I am not sure this is the expected behavior.

[WebKit Commit Bot]

Comment on attachment 307243 [details]
Patch

Clearing flags on attachment: 307243

Committed r215412: <http://trac.webkit.org/changeset/215412>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.