RESOLVED FIXED 170892
[Cocoa] Move isNullFunctionPointer down into WTF 
https://bugs.webkit.org/show_bug.cgi?id=170892
Summary [Cocoa] Move isNullFunctionPointer down into WTF
mitz
Reported 2017-04-16 14:03:18 PDT
Rather than having a copy of isNullFunctionPointer() in each source file that uses it, we can put it in a WTF header.
Attachments
Patch for EWS (19.28 KB, patch)
2017-04-16 15:04 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Patch for EWS (19.30 KB, patch)
2017-04-16 15:56 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Move the function to wtf/darwin/WeakLinking.h (22.50 KB, patch)
2017-04-16 17:08 PDT, mitz 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2017-04-16 15:04:54 PDT
Created attachment 307241 [details] Patch for EWS
mitz
Comment 2 2017-04-16 15:56:30 PDT
Created attachment 307244 [details] Patch for EWS
mitz
Comment 3 2017-04-16 17:08:00 PDT
Created attachment 307250 [details] Move the function to wtf/darwin/WeakLinking.h
mitz
Comment 4 2017-04-16 17:08:40 PDT
Not sure I picked the best place in WTF for this function.
Sam Weinig
Comment 5 2017-04-16 17:14:40 PDT
Comment on attachment 307250 [details] Move the function to wtf/darwin/WeakLinking.h View in context: https://bugs.webkit.org/attachment.cgi?id=307250&action=review > Source/WTF/wtf/darwin/WeakLinking.h:27 > + Probably worth including <type_traits> to make this compile standalone.
mitz
Comment 6 2017-04-17 13:22:40 PDT
Committed <https://trac.webkit.org/r215424>.
Note You need to log in before you can comment on or make changes to this bug.